refactor(ci): drop redundant if condition in main.yml#61
Merged
Conversation
The release job had a broad `if:` condition that just re-checked the event type. Simplify: filter in the trigger, drop the if. Also add `repository_dispatch` to the triggers for consistency.
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: da42d23 This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The release job had a broad
if:condition (github.event_name == '\''push'\'' || ... == '\''workflow_dispatch'\'') that just re-checked the event type. The trigger already filters by event, so theifis always true (dead code). It also forgotrepository_dispatch, which is supported by the rest of the dappnode org and the SDK.Approach
if:condition on the release job.repository_dispatchto theon:triggers (so external API dispatches also fire the release, matching the other repos).actions/setup-nodev4 → v6 to match the other repos.The resulting pattern is now identical to the other dappnode packages that already went through this refactor (DMS, DNP_IPFS, DNP_NOTIFICATIONS, n8n, obol-generic, juno-generic, Hermes-agent, openclaw, tailscale).
Test instructions
Buildworkflow runs once, posts an IPFS hash comment.Mainworkflow runs the release.workflow_dispatch→Mainworkflow runs the release.