Skip to content

fix: remove duplicate BTC_RPCPORT=8333 (use 8332) and drop build_0.1.6 artifacts#60

Merged
3alpha merged 1 commit into
masterfrom
fix/rpcport-8332
Jul 8, 2026
Merged

fix: remove duplicate BTC_RPCPORT=8333 (use 8332) and drop build_0.1.6 artifacts#60
3alpha merged 1 commit into
masterfrom
fix/rpcport-8332

Conversation

@3alpha

@3alpha 3alpha commented Jul 8, 2026

Copy link
Copy Markdown
Member

Problem

docker-compose.yml declared BTC_RPCPORT twice:

- BTC_RPCPORT=8332   # added in PR #45 (8ea3d98, "add rpcport as env")
...
- BTC_RPCPORT=8333   # added in PR #48 (f0b0077, "Fix missing rpc port")

Docker Compose merges duplicate environment keys last-wins, so the
container actually received BTC_RPCPORT=8333. That is the mainnet P2P
port (and this package already maps P2P to 8340 via P2P_PORT=8340),
so the JSON-RPC server was attempting to bind the same port as the
peer-to-peer listener.

The entrypoint default in src/docker_entrypoint.sh is already
rpcport=${BTC_RPCPORT:-8332}, and EXPOSE documents 8332/8333,
so the intended value is 8332 (the mainnet JSON-RPC port).

Fix

  • Remove the duplicate BTC_RPCPORT=8333 line, keeping the original
    BTC_RPCPORT=8332 from PR bump bitcoin/bitcoin to v26.2 #45.
  • Drop stale build_0.1.6/ artifacts (avatar, tarballs, manifest,
    compose) that should not have been tracked in git.

Verification

After this change:

environment:
  - BTC_RPCPORT=8332
  - P2P_PORT=8340
ports:
  - "8340:8340"

bitcoin.conf will set rpcport=8332 and bitcoind will listen
for P2P traffic on 8340 — no port collision, matches the entrypoint
defaults and the standard mainnet convention.

Refs: PR #45 (8ea3d98), PR #48 (f0b0077)

…6 artifacts

- docker-compose.yml had BTC_RPCPORT declared twice (8332 from PR #45 and
  8333 from PR #48). Compose merges duplicate env keys last-wins, so the
  container actually received 8333 (the mainnet P2P port), conflicting with
  P2P_PORT=8340. Drop the 8333 entry; keep the 8332 entry from the original
  PR #45 'add rpcport as env' to match the entrypoint default
  (rpcport=${BTC_RPCPORT:-8332}) and the standard mainnet JSON-RPC port.
- Remove stale build_0.1.6/ artifacts (avatar, tarballs, manifest, compose).
@tropibot

tropibot Bot commented Jul 8, 2026

Copy link
Copy Markdown

Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 70d4cb3

This is a development version and should only be installed for testing purposes.

  1. Package bitcoin.dnp.dappnode.eth

Install link

Hash: /ipfs/QmYR36P8ngNKXSKGv2ccv5UXzAXVjwaWYKk6BvGqP52uJs

(by dappnodebot/build-action)

@3alpha 3alpha merged commit c9f4f61 into master Jul 8, 2026
2 checks passed
@3alpha 3alpha deleted the fix/rpcport-8332 branch July 8, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant