Repository navigation
chore(config): raise probe interval to 60s, recheck threshold to 120s - #195
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Teebor-Choka
requested review from
Jaguaras and
tolbrino
and
a balanced review from Copilot
and removed request for
tolbrino
October 12, 2026 10:25
There was a problem hiding this comment.
🟡 Changes recommended
The configured values diverge from the upstream defaults despite the PR description claiming they mirror them.
1 open finding
What changed in this PR
Raises HOPR node probe timings to reduce probing frequency.
Changes:
- Increases probe rounds from 30s to 60s.
- Increases neighbor rechecks from 60s to 120s.
| File | Description |
|---|---|
hoprd.cfg.yaml |
Updates network probe timing overrides. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes node probing less aggressive by doubling both probing knobs in
hoprd.cfg.yaml:probe_interval:30s→60s(delay between probing rounds)probe_recheck_threshold:60s→120s(time after which the nearest neighbor is re-probed)Mirrors the same change made to the hoprd default and compose configs upstream (hoprnet/hoprd). Config-only change, no package version bump (matches prior config PRs, e.g. #194).
Validated as syntactically valid YAML locally;
test/validate-hoprd-config.sh(thehoprd-cfg --validate-argscheck against the 5.0.0-rc.1 image) runs in CI.