ci: use dappnode-build-hash reusable workflow#165
Open
3alpha wants to merge 3 commits into
Open
Conversation
Replaces the inlined build-test (which used `--skip_save` and never posted an IPFS hash on PRs) with a thin caller for the new `dappnode/workflows/.github/workflows/dappnode-build-hash.yml@master` reusable workflow. `build.yml` now handles both push and PR events; `main.yml` is reduced to the release job only. Also upgrades `actions/checkout` to v7 and adds Node 24 setup for the release job.
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: aa04f62 This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
The `push` event already fires when tropibot pushes commits to the feature branch, so the build, IPFS pin, and PR comment all happen once per commit. The `pull_request` event was firing the same workflow a second time as a no-op (--skip_save test build). The reusable workflow SDK auto-detects the event: `push` to a non-default branch builds + pins + comments, `push` to default does a test build, and (now unused) `pull_request` would do a test build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This repo's
main.ymlran abuild-teststep with--skip_save, which never pinned to IPFS or posted a comment on the PR. As a result tropibot PRs (e.g. #162) had no build artifact for testers to install.Approach
.github/workflows/build.yml— a thin stub that calls the newdappnode/workflows/.github/workflows/dappnode-build-hash.yml@masterreusable workflow withsecrets: inherit. Pins to Pinata and posts the IPFS hash comment on every push (non-default branch) and PR..github/workflows/main.ymlto the release job only. Dropbuild-test(now handled bybuild.yml), drop thepull_requesttrigger from main, upgradeactions/checkoutto v7 and add Node 24 setup.Test instructions
Buildworkflow runs and posts a comment with an IPFS install link and hash tagged(by dappnodebot/build-action).master, theMainworkflow should run the release.