DAOS-19281 control: Suppress storage tier ratio warning for MD-on-SSD pools#18619
DAOS-19281 control: Suppress storage tier ratio warning for MD-on-SSD pools#18619tanabarr wants to merge 4 commits into
Conversation
Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
|
Ticket title is 'Remove NOTICE: storage tier ratio is less than 1.00%, DAOS performance will suffer! during pool create under MDonSSD environment.' |
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18619/2/execution/node/1393/log |
knard38
left a comment
There was a problem hiding this comment.
Mostly OK for me, just the warning message needs to be fixed and the copyright of the pool_test.go file needs to be updated.
|
|
||
| // Warn if ratio is below minimum for PMem mode (SCM:NVMe) | ||
| if percentage < minPercentage { | ||
| return fmt.Sprintf("NOTICE: storage tier ratio is less than %0.2f%%, DAOS performance will suffer!", minPercentage) |
There was a problem hiding this comment.
The NOTICE: should be removed here as it will be already added from the caller of this function.
| return fmt.Sprintf("NOTICE: storage tier ratio is less than %0.2f%%, DAOS performance will suffer!", minPercentage) | |
| return fmt.Sprintf("storage tier ratio is less than %0.2f%%, DAOS performance will suffer!", minPercentage) |
The unit test Test_checkPoolCreateTierRatioWarning() should also be updated accordingly.
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
…move-scmratio-warning Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
|
Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18619/4/testReport/ |
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
|
Test stage Functional Cluster Box Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18619/5/execution/node/1662/log |
Remove misleading low tier ratio warning when creating pools with
MD-on-SSD enabled. Low metadata-to-data ratios (~0.7%) are normal
and expected in MD-on-SSD mode, unlike PMem mode where <6% ratios
may impact performance. Add comprehensive unit tests.
Features: control
Steps for the author:
After all prior steps are complete: