Skip to content

DAOS-19281 control: Suppress storage tier ratio warning for MD-on-SSD pools#18619

Open
tanabarr wants to merge 4 commits into
masterfrom
tanabarr/control-remove-scmratio-warning
Open

DAOS-19281 control: Suppress storage tier ratio warning for MD-on-SSD pools#18619
tanabarr wants to merge 4 commits into
masterfrom
tanabarr/control-remove-scmratio-warning

Conversation

@tanabarr

@tanabarr tanabarr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Remove misleading low tier ratio warning when creating pools with
MD-on-SSD enabled. Low metadata-to-data ratios (~0.7%) are normal
and expected in MD-on-SSD mode, unlike PMem mode where <6% ratios
may impact performance. Add comprehensive unit tests.

Features: control

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr self-assigned this Jul 7, 2026
@tanabarr tanabarr requested review from a team as code owners July 7, 2026 14:07
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Ticket title is 'Remove NOTICE: storage tier ratio is less than 1.00%, DAOS performance will suffer! during pool create under MDonSSD environment.'
Status is 'In Review'
Labels: '2.8.0rc1,md_on_ssd,test_2.8.0rc'
https://daosio.atlassian.net/browse/DAOS-19281

@tanabarr tanabarr changed the title fDAOS-19281 control: Remove storage tier warning for MD-on-SSD DAOS-19281 control: Remove storage tier warning for MD-on-SSD Jul 7, 2026
kjacque
kjacque previously approved these changes Jul 7, 2026
@tanabarr tanabarr changed the title DAOS-19281 control: Remove storage tier warning for MD-on-SSD DAOS-19281 control: Suppress storage tier ratio warning for MD-on-SSD pools Jul 8, 2026
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18619/2/execution/node/1393/log

@tanabarr tanabarr requested a review from knard38 July 9, 2026 13:50

@knard38 knard38 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly OK for me, just the warning message needs to be fixed and the copyright of the pool_test.go file needs to be updated.

Comment thread src/control/cmd/dmg/pool.go Outdated

// Warn if ratio is below minimum for PMem mode (SCM:NVMe)
if percentage < minPercentage {
return fmt.Sprintf("NOTICE: storage tier ratio is less than %0.2f%%, DAOS performance will suffer!", minPercentage)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NOTICE: should be removed here as it will be already added from the caller of this function.

Suggested change
return fmt.Sprintf("NOTICE: storage tier ratio is less than %0.2f%%, DAOS performance will suffer!", minPercentage)
return fmt.Sprintf("storage tier ratio is less than %0.2f%%, DAOS performance will suffer!", minPercentage)

The unit test Test_checkPoolCreateTierRatioWarning() should also be updated accordingly.

tanabarr added 2 commits July 10, 2026 11:49
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
…move-scmratio-warning

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@daosbuild3

Copy link
Copy Markdown
Collaborator

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Cluster Box Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18619/5/execution/node/1662/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants