DAOS-19249 dfs: support xattr operations on hardlinks#18611
Open
sherintg wants to merge 1 commit into
Open
Conversation
Store extended attributes for hardlinked files in the Global Inode Table (GIT) keyed by OID so all links share a single set of xattrs. dfs_setxattr, dfs_getxattr, dfs_removexattr and dfs_listxattr now detect when a dfs_obj carries a stale mode (opened while the entry was still a regular file) and transparently retry against GIT once the on-disk entry has been converted to a hardlink. dfs_setxattr additionally serializes concurrent hardlink conversion and xattr updates using a balanced-mode DTX when enabled, performing an explicit existence check in place of conditional akey updates. Add DFS_UNIT_TEST30 covering get/set/list/remove across stale handles and multiple links, flag semantics, persistence and post-unlink behavior. Allow-unstable-test: true Signed-off-by: Sherin T George <sherin-t.george@hpe.com>
|
Ticket title is 'Add hardlink support to DFS xattr APIs' |
mchaarawi
requested changes
Jul 7, 2026
Comment on lines
+118
to
+123
| /* | ||
| * Since this function deals with dfs_obj, the hardlink information in its | ||
| * mode field may be outdated. Check and update the mode with hardlink info. | ||
| * Retry if the hardlink bit is set. | ||
| */ | ||
| if (S_ISREG(obj->mode)) { |
Contributor
There was a problem hiding this comment.
IMO this is changing the original behavior. this is not acceptable.
You are revalidating the entry and adding and extra fetch. DFS already has this in many places, where the user is responsible of revalidating or close/reopening entries.
What if the entry handle changes under you right after this fetch completes?
| check_iod.iod_type = DAOS_IOD_SINGLE; | ||
| check_iod.iod_size = DAOS_REC_ANY; | ||
| rc = daos_obj_fetch(oh, th, DAOS_COND_AKEY_FETCH, &dkey, 1, &check_iod, NULL, NULL, | ||
| NULL); |
Contributor
There was a problem hiding this comment.
i believe ALL conditionals do not work properly with a DTX.
IMO you should just do the same logic as was done without a GIT, but for a hardlink file you do it in the GIT object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store extended attributes for hardlinked files in the Global Inode Table (GIT) keyed by OID so all links share a single set of xattrs. dfs_setxattr, dfs_getxattr, dfs_removexattr and dfs_listxattr now detect when a dfs_obj carries a stale mode (opened while the entry was still a regular file) and transparently retry against GIT once the on-disk entry has been converted to a hardlink.
dfs_setxattr additionally serializes concurrent hardlink conversion and xattr updates using a balanced-mode DTX when enabled, performing an explicit existence check in place of conditional akey updates.
Add DFS_UNIT_TEST30 covering get/set/list/remove across stale handles and multiple links, flag semantics, persistence and post-unlink behavior.
Allow-unstable-test: true
Steps for the author:
After all prior steps are complete: