Bootstrap main components repo with crow_alarm_panel and uv dev environment by Copilot · Pull Request #1 · dan-s-github/esphome-components

Copilot · 2026-04-01T05:24:24Z

Establishes this repo as the canonical home for custom ESPHome components, with a components/ directory layout and a uv-managed Python environment for local compilation and validation.

Changes

Component: `crow_alarm_panel`

Ported all source files from dan-s-github/esphome-components-jallier into components/crow_alarm_panel/
Preserves full sub-component structure: alarm_control_panel, binary_sensor, button, switch, text_sensor
C++ sources: crow_alarm_panel.h, crow_alarm_panel.cpp, crow_alarm_control_panel.cpp

Build environment

pyproject.toml declares esphome>=2026.3.0 as a dependency, managed via uv
Local workflow: uv sync && source .venv/bin/activate then standard esphome CLI

Test configuration

crow_alarm_panel_test.yaml — sample ESP32 config exercising all sub-platforms for local esphome config / esphome compile validation

Repo hygiene

.gitignore — added .venv/ and uv.lock
README.md — documents setup steps and external_components usage pattern:

external_components:
  - source:
      type: git
      url: https://github.com/dan-s-github/esphome-components
      ref: main
    components: [crow_alarm_panel]

…e docs Agent-Logs-Url: https://github.com/dan-s-github/esphome-components/sessions/f8015637-c53d-44c0-b32f-2fa463f91642 Co-authored-by: dan-s-github <20974454+dan-s-github@users.noreply.github.com>

dan-s-github · 2026-04-01T05:33:08Z

@copilot change merge target to dev

Copilot

Pull request overview

Bootstraps this repository as a home for custom ESPHome components by adding a components/ layout, a uv-managed Python environment for local validation, and an initial crow_alarm_panel external component with a sample compile/test configuration.

Changes:

Added repo documentation and a local uv-based workflow for running esphome config/compile.
Introduced components/crow_alarm_panel component with multiple sub-platforms (ACP, button, switch, binary_sensor, text_sensor) and C++ bus handling.
Added a sample crow_alarm_panel_test.yaml for local validation/compilation and updated repo hygiene (.gitignore).

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
README.md	Documents repo purpose, `uv` workflow, and `external_components` usage.
pyproject.toml	Defines a `uv`-managed Python environment with an ESPHome dependency.
crow_alarm_panel_test.yaml	Provides a sample ESP32 configuration to validate/compile the component.
.gitignore	Ignores `.venv/` and `uv.lock` for the `uv` workflow.
components/crow_alarm_panel/init.py	Core component schema/codegen for pins, keypad address, keypads list, and `on_message` trigger.
components/crow_alarm_panel/README.md	Component-specific documentation and YAML example.
components/crow_alarm_panel/crow_alarm_panel.h	Declares the main C++ component, ISR store, and platform integration hooks.
components/crow_alarm_panel/crow_alarm_panel.cpp	Implements bus ISR receive logic, packet TX, message decoding, and arm/disarm sequencing.
components/crow_alarm_panel/crow_alarm_control_panel.cpp	Implements ACP `control()` mapping to arm/disarm actions.
components/crow_alarm_panel/alarm_control_panel/init.py	ESPHome ACP platform codegen wiring to the parent component.
components/crow_alarm_panel/binary_sensor/init.py	ESPHome binary_sensor platform codegen for zone/bypass.
components/crow_alarm_panel/button/init.py	ESPHome button platform codegen for arm/disarm actions.
components/crow_alarm_panel/button/crow_alarm_panel_button.h	C++ button implementation mapping presses to parent actions.
components/crow_alarm_panel/switch/init.py	ESPHome switch platform codegen for output control.
components/crow_alarm_panel/switch/crow_alarm_panel_switch.h	C++ switch base/derived classes for Crow outputs.
components/crow_alarm_panel/switch/crow_alarm_panel_switch.cpp	C++ switch implementations calling parent output control and logging config.
components/crow_alarm_panel/text_sensor/init.py	ESPHome text_sensor platform codegen for armed state reporting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T05:46:18Z

+| Component | Description |
+|-----------|-------------|
+| [crow_alarm_panel](components/crow_alarm_panel/README.md) | Integration for Arrowhead Crow alarm panels via the keypad bus |


The Markdown table has an extra leading | on the header/separator rows (|| ...), which prevents the table from rendering correctly. Replace || with a single | on those lines.

@copilot I don't see an extra leading |

You're right — the table in README.md is correctly formatted with single | delimiters. The reviewer comment was incorrect; no change is needed here.

Copilot · 2026-04-01T05:46:21Z

+      case ARMED_STATE: {
+        if (armed_state_ != nullptr) {
+          if (data[0] == 0x00 && data[1] == 0x01) {
+            this->armed_state_->publish_state("arming");
+            ESP_LOGD(TAG, "Arming [%02x.%s]", type, format_hex_pretty(data).c_str());
+            if (this->alarm_control_panel_ != nullptr) {
+              this->alarm_control_panel_->publish_state(alarm_control_panel::ACP_STATE_ARMING);
+            }
+          } else if (data[0] == 0x01 && data[1] == 0x00) {
+            this->armed_state_->publish_state("armed_away");


In the ARMED_STATE handler, the code reads data[0] and data[1] without checking data.size(). If a short/empty frame is received, this will read out of bounds. Add a length guard (e.g., require at least 2 bytes) before accessing.

@copilot apply changes based on this feedback

Done in commit 5cae879. Added a data.size() < 2 guard at the top of the ARMED_STATE case — if the frame is too short, it logs a warning and breaks without accessing data[0]/data[1].

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-04-01T07:17:54Z

@copilot change merge target to dev

The merge target is already set to dev — the PR base branch was updated in a previous session.

Agent-Logs-Url: https://github.com/dan-s-github/esphome-components/sessions/f36df2a9-98b4-4f85-b1e8-5106e6e7aad2 Co-authored-by: dan-s-github <20974454+dan-s-github@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dan-s-github/esphome-components/sessions/789e0231-e4fd-49b3-aeab-47f24a93a9d2 Co-authored-by: dan-s-github <20974454+dan-s-github@users.noreply.github.com>

dan-s-github · 2026-04-01T07:43:59Z

@copilot in a follow-up session

Add components/crow_alarm_panel, pyproject.toml, test YAML, and updat…

46b4b6a

…e docs Agent-Logs-Url: https://github.com/dan-s-github/esphome-components/sessions/f8015637-c53d-44c0-b32f-2fa463f91642 Co-authored-by: dan-s-github <20974454+dan-s-github@users.noreply.github.com>

Copilot AI assigned Copilot and dan-s-github Apr 1, 2026

Copilot created this pull request from a session on behalf of dan-s-github April 1, 2026 05:24 View session

dan-s-github requested a review from Copilot April 1, 2026 05:41

Copilot started reviewing on behalf of dan-s-github April 1, 2026 05:42 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

Copilot started work on behalf of dan-s-github April 1, 2026 06:46 View session

Copilot finished work on behalf of dan-s-github April 1, 2026 06:48

Copilot AI requested a review from dan-s-github April 1, 2026 06:48

dan-s-github changed the base branch from main to dev April 1, 2026 07:03

Apply suggestions from code review

790b8c1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

dan-s-github requested changes Apr 1, 2026

View reviewed changes

Copilot started work on behalf of dan-s-github April 1, 2026 07:17 View session

Make address required in crow_alarm_panel config schema

5184502

Agent-Logs-Url: https://github.com/dan-s-github/esphome-components/sessions/f36df2a9-98b4-4f85-b1e8-5106e6e7aad2 Co-authored-by: dan-s-github <20974454+dan-s-github@users.noreply.github.com>

Copilot finished work on behalf of dan-s-github April 1, 2026 07:20

Copilot AI requested a review from dan-s-github April 1, 2026 07:20

Copilot started work on behalf of dan-s-github April 1, 2026 07:29 View session

dan-s-github and others added 2 commits April 1, 2026 20:30

Update components/crow_alarm_panel/crow_alarm_panel.cpp

68097cd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Add data size guard in ARMED_STATE handler to prevent out-of-bounds read

5cae879

Agent-Logs-Url: https://github.com/dan-s-github/esphome-components/sessions/789e0231-e4fd-49b3-aeab-47f24a93a9d2 Co-authored-by: dan-s-github <20974454+dan-s-github@users.noreply.github.com>

Copilot finished work on behalf of dan-s-github April 1, 2026 07:32

Copilot started work on behalf of dan-s-github April 1, 2026 07:44 View session

dan-s-github marked this pull request as ready for review April 1, 2026 07:45

Copilot stopped work on behalf of dan-s-github due to an error April 1, 2026 07:45
The session was cancelled by the user.

dan-s-github merged commit 0fe42d5 into dev Apr 1, 2026
1 check failed

dan-s-github deleted the copilot/setup-components-folder branch April 1, 2026 07:48

Conversation

Copilot AI commented Apr 1, 2026

Changes

Component: crow_alarm_panel

Build environment

Test configuration

Repo hygiene

Uh oh!

dan-s-github commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

dan-s-github Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

dan-s-github Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Apr 1, 2026

Uh oh!

dan-s-github commented Apr 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Component: `crow_alarm_panel`

dan-s-github commented Apr 1, 2026 •

edited

Loading

dan-s-github Apr 1, 2026 •

edited

Loading