Skip to content

Handle empty bulk enqueue #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caomengxuan666 wants to merge 1 commit into
base: master
Choose a base branch
from
+23 −2
Open

Handle empty bulk enqueue #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion include/daking/MPSC_queue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,9 @@ namespace daking {
DAKING_ALWAYS_INLINE void enqueue_bulk(const_reference value, size_type n) {
// N times thread_local operation, One time CAS operation.
// So it is more efficient than N times enqueue.
if (n == 0) {
return;
}

node_t* first_new_node = _allocate();
node_t* prev_node = first_new_node;
Expand All @@ -511,6 +514,9 @@ namespace daking {
"Iterator must be at least input iterator.");
static_assert(std::is_same_v<typename std::iterator_traits<InputIt>::value_type, value_type>,
"The value type of iterator must be same as MPSC_queue::value_type.");
if (n == 0) {
return;
}

node_t* first_new_node = _allocate();
node_t* prev_node = first_new_node;
Expand Down Expand Up @@ -743,4 +749,4 @@ namespace daking {
};
}

#endif // !DAKING_MPSC_QUEUE_HPP
#endif // !DAKING_MPSC_QUEUE_HPP
17 changes: 16 additions & 1 deletion tests/test_MPSC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,21 @@ TEST(MPSCQueueBulkTest, EnqueueBulk_InputIterator) {
EXPECT_TRUE(queue.empty());
}

TEST(MPSCQueueBulkTest, EnqueueBulk_EmptyRangeIsNoOp) {
TestQueue queue;
const int value = 99;
std::vector<int> data;

queue.enqueue_bulk(value, 0);
EXPECT_TRUE(queue.empty());

queue.enqueue_bulk(data.begin(), data.size());
EXPECT_TRUE(queue.empty());

queue.enqueue_bulk(data.begin(), data.end());
EXPECT_TRUE(queue.empty());
}

TEST(MPSCQueueBulkTest, TryDequeueBulk_Partial) {
TestQueue queue;
queue.enqueue(1);
Expand Down Expand Up @@ -306,4 +321,4 @@ TEST(MPSCQueueBlockTest, DequeueBulk_BlockAndWait) {
EXPECT_EQ(results[2], 3);
EXPECT_TRUE(queue.empty());
}
#endif
#endif