Skip to content

correct some intent and shared hungarian tests hungarian intent property translations#615

Open
hammera wants to merge 1 commit into
daisy:hufrom
hammera:hu
Open

correct some intent and shared hungarian tests hungarian intent property translations#615
hammera wants to merge 1 commit into
daisy:hufrom
hammera:hu

Conversation

@hammera

@hammera hammera commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Hy Boys,

In #557 issue @MartheGjelstad intent attribute tests related answer, I doed some cosmetic changes with tests/language/hu/shared.rs file and tests/languages/hu/intent.rs files related.
Previous, the „perpendicular to” string, the „testing of” string parts (normal and prefix type test), and the „forced” string parts are presents untranslated, because I not known previous this string parts are need translate inside the MathML expression the intent attribute part into the affected tests, not with any Rules/Languages/hu awailable rule files. :-):-)
Have two test with me need restore after the main branch merge happened, because have differences the april 24 branch state of the hu branch and the actual branch state with two tests related.
So, now only have 523 hungarian tests again.

In my local machine following commands ran successfull:

  • cargo build,
  • cargo test Languages::hu,
  • cargo test --lib (navigation tests),
  • cargo check.

Cargo clippy me drops following output:

warning: casting to the same type is unnecessary (`u32` -> `u32`)
    --> src/speech.rs:2828:147
     |
2828 | ...32(*ch).unwrap(), *ch as u32);
     |                      ^^^^^^^^^^ help: try: `{ *ch }`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_cast
     = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: `mathcat` (lib) generated 1 warning (run `cargo clippy --fix --lib -p mathcat` to apply 1 suggestion)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s

Cargo test command drops me following result, I copyed only end of results:

failures:
    braille::Swedish::swedish::ex_6_15
    braille::Swedish::swedish::ex_6_16
    braille::Swedish::swedish::ex_6_19

test result: FAILED. 1422 passed; 3 failed; 31 ignored; 0 measured; 0 filtered out; finished in 6.22s

This result is equals the friday evening result, when the merge happened from the hu branch of the main branch.

Please merge this corrected tests into the github.com/daisy/mathcat repository hu branch, and after this merge, if this is possible please merge this change to the github.com/daisy/mathcat repo main branch too.

Thank you the very good cooperation,

Attila

…rty translations

Signed-off-by: Attila Hammer <hammera@pickup.hu>
@hammera

hammera commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Cargo clippy related online workflow check produce exit code 101 error.
The log file show following, this is I think not related the hungarian tests related fix with I committed this day.
If this is not the case, please tell me what can me need fixing the affected test Rust files and I will doing the proper fix.
The log file output:

    Checking env_logger v0.11.11
error: casting to the same type is unnecessary (`u32` -> `u32`)
    --> src/speech.rs:2828:147
     |
2828 | ... unicode tables", char::from_u32(*ch).unwrap(), *ch as u32);
     |                                                    ^^^^^^^^^^ help: try: `{ *ch }`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_cast
     = note: `-D clippy::unnecessary-cast` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`

error: could not compile `mathcat` (lib) due to 1 previous error
Error: Process completed with exit code 101.

Attila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant