Skip to content

fix(sentiment): preserve commentful source rows#6372

Open
rebelchris wants to merge 1 commit into
mainfrom
codex/fix-sentiment-source-thread-match
Open

fix(sentiment): preserve commentful source rows#6372
rebelchris wants to merge 1 commit into
mainfrom
codex/fix-sentiment-source-thread-match

Conversation

@rebelchris

@rebelchris rebelchris commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • resolve source rows against all matching discussions instead of a single provider map entry
  • prefer exact source URLs and keep rows when any matching discussion has comments
  • add regression coverage for HN with no comments plus Lobsters with comments

Tests

  • NODE_ENV=test node_modules/.bin/jest src/components/post/focus/CommunitySentimentBreakdown.spec.tsx --runInBand (packages/shared)
  • node_modules/.bin/prettier --check src/components/post/focus/CommunitySentimentBreakdown.tsx src/components/post/focus/CommunitySentimentBreakdown.spec.tsx (packages/shared)
  • node ./scripts/typecheck-strict-changed.js
  • NODE_ENV=test node_modules/.bin/jest --runInBand (packages/webapp)

Preview domain

https://codex-fix-sentiment-source-threa.preview.app.daily.dev

@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Jul 23, 2026 5:43pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Jul 23, 2026 5:43pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant