feat: KafkaTransportOptions for configurable Kafka outbox transport#426
Open
feat: KafkaTransportOptions for configurable Kafka outbox transport#426
Conversation
6 tasks
Copilot
AI
changed the title
[WIP] Add KafkaTransportOptions for configurable Kafka outbox transport
feat: KafkaTransportOptions for configurable Kafka outbox transport
Apr 18, 2026
85262ad to
8dbdfce
Compare
- Add KafkaTransportOptions with DefaultPartitionCount, DefaultReplicationFactor, AutoCreateTopics, MessageRetention - Update KafkaMessageTransport to inject IOptions<KafkaTransportOptions> and auto-create topics - Update UseKafkaTransport() to accept Action<KafkaTransportOptions>? configureOptions parameter - Add unit tests for all new options (partition count, replication factor, AutoCreateTopics=false, retention, constructor null check)" Agent-Logs-Url: https://github.com/dailydevops/pulse/sessions/6dda0741-f9e5-4596-9ad2-028cc33d0cbc Co-authored-by: samtrion <3283596+samtrion@users.noreply.github.com>
…essage justification Agent-Logs-Url: https://github.com/dailydevops/pulse/sessions/6dda0741-f9e5-4596-9ad2-028cc33d0cbc Co-authored-by: samtrion <3283596+samtrion@users.noreply.github.com>
8dbdfce to
b9ad6cb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
+ Coverage 92.13% 92.19% +0.06%
==========================================
Files 151 152 +1
Lines 5591 5626 +35
Branches 524 529 +5
==========================================
+ Hits 5151 5187 +36
+ Misses 292 291 -1
Partials 148 148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka was the only Pulse transport without a dedicated options class — topic creation used hard-coded partition count and replication factor with no way to configure retention or disable auto-creation.
Changes
New:
KafkaTransportOptionsKafkaMessageTransportIOptions<KafkaTransportOptions>EnsureTopicAsync(): creates the topic before first produce to a given topic name, cached viaConcurrentDictionaryto avoid redundant admin callsAutoCreateTopics = falseretention.msto topic config whenMessageRetentionis setTopicAlreadyExistserrors gracefullyUseKafkaTransport()extensionAction<KafkaTransportOptions>? configureOptions = nullIOptions<KafkaTransportOptions>viaAddOptions/ConfigureTests
FakeAdminClientupdated to trackCreateTopicsAsynccalls (CreatedTopics,CreateTopicsCallCount)UseKafkaTransportwith and without options delegate, constructor null guard