feat: implement SendBatchAsync and integration tests for NetEvolve.Pulse.RabbitMQ#423
Open
feat: implement SendBatchAsync and integration tests for NetEvolve.Pulse.RabbitMQ#423
Conversation
8 tasks
Copilot
AI
changed the title
[WIP] Add RabbitMQ transport for outbox processor
feat: implement SendBatchAsync and integration tests for NetEvolve.Pulse.RabbitMQ
Apr 17, 2026
ec55d7e to
47ebc70
Compare
47ebc70 to
75000e6
Compare
…itMQ transport Agent-Logs-Url: https://github.com/dailydevops/pulse/sessions/3e8d71d0-5c05-4a68-91c3-639f8e6b0900 Co-authored-by: samtrion <3283596+samtrion@users.noreply.github.com>
75000e6 to
1c7b723
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RabbitMQ transport (
NetEvolve.Pulse.RabbitMQ) was missing aSendBatchAsyncoverride, leaving it reliant on the defaultParallel.ForEachAsyncimplementation — which causes concurrent access on a sharedIChannelthat is not thread-safe. Integration tests against a real broker were also absent.Transport changes
RabbitMqMessageTransport: addedSendBatchAsyncoverride that acquires the channel once and publishes all messages sequentially on that single channelPublishAsynchelper shared by bothSendAsyncandSendBatchAsyncto eliminate duplicationUnit tests (
NetEvolve.Pulse.Tests.Unit)Added five tests for
SendBatchAsynccovering:SendAsynccallsIntegration tests (
NetEvolve.Pulse.Tests.Integration)RabbitMqContainerFixture: manages aTestcontainers.RabbitMqcontainer lifecycle per test sessionRabbitMqMessageTransportIntegrationTests: verifiesSendAsync,SendBatchAsync, andIsHealthyAsync(before first send →false; after first send with open connection →true) against a live broker