Skip to content

fix(typing): fix mypy errors in indexing with numpy 2.5.1 stubs #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-v-b wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(typing): fix mypy errors in indexing with numpy 2.5.1 stubs #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/zarr/core/indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,8 @@ def replace_ellipsis(selection: Any, shape: tuple[int, ...]) -> SelectionNormali

def replace_lists(selection: SelectionNormalized) -> SelectionNormalized:
return tuple(
np.asarray(dim_sel) if isinstance(dim_sel, list) else dim_sel for dim_sel in selection
cast("ArrayOfIntOrBool", np.asarray(dim_sel)) if isinstance(dim_sel, list) else dim_sel
for dim_sel in selection
)


Expand Down Expand Up @@ -1192,7 +1193,7 @@ def __init__(
# some initial normalization
selection_normalized = cast("CoordinateSelectionNormalized", ensure_tuple(selection))
selection_normalized = tuple(
np.asarray([i]) if is_integer(i) else i for i in selection_normalized
np.asarray([i], dtype=np.intp) if is_integer(i) else i for i in selection_normalized
)
selection_normalized = cast(
"CoordinateSelectionNormalized", replace_lists(selection_normalized)
Expand Down
Loading