-
Notifications
You must be signed in to change notification settings - Fork 1
Release 1.0.0: remove support for Python 3.6, 3.7; fix linting errors #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b735d60
aa04d43
7edc159
01bff49
e866deb
e068f47
880bd73
d7873fe
c747ab1
c65edf8
5a8da0c
c6b8a3f
1688eba
1fc2506
9f4d991
22b9a98
c761e31
5b5a65b
d5ded78
7673d4e
de0ee97
ddc5d6a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [bumpversion] | ||
| current_version = 0.0.2 | ||
| current_version = 1.0.0 | ||
| parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+) | ||
| serialize = | ||
| {major}.{minor}.{patch} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: Lint | ||
|
|
||
| on: [push] | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: "3.10" | ||
| cache: 'pip' | ||
| cache-dependency-path: setup.py | ||
|
|
||
| - run: pip3 install -e '.[test]' | ||
| - run: make lint-ci |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,3 +11,4 @@ build | |
| .idea/ | ||
| .python-version | ||
| venv | ||
| .venv | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| [env] | ||
| MISE_FETCH_REMOTE_VERSIONS_TIMEOUT = "30s" | ||
|
|
||
| _.python.venv = { | ||
| path = ".venv", | ||
| create = true, | ||
| } | ||
|
|
||
| [settings] | ||
| python.uv_venv_auto = false | ||
| python.venv_stdlib = true | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer using venv over uv, and ensure that pip is installed in the venv. |
||
|
|
||
| [tools] | ||
| python = "3.11" | ||
|
|
||
| [tasks.test] | ||
| run = 'make install test' | ||
|
|
||
| [tasks.lint] | ||
| run = 'make install lint' | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,18 @@ install: | |
| pip install --edit .[test] | ||
|
|
||
| test: | ||
| pylint --rcfile=.pylintrc --reports=y --exit-zero customerio/analytics | ||
| flake8 --max-complexity=10 --statistics customerio/analytics || true | ||
| python -m unittest customerio/analytics/test/*.py -v | ||
|
|
||
| .PHONY: install test | ||
| lint: | ||
| pylint --rcfile=.pylintrc --reports=y --exit-zero customerio/analytics | ||
| flake8 --max-complexity=10 --statistics --exit-zero customerio/analytics | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Invalid flake8 exit-zero flagMedium Severity The local Reviewed by Cursor Bugbot for commit 7673d4e. Configure here.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Back in reality, this does not happen, and the command completes successfully with flake 3.7.9. |
||
|
|
||
| lint-ci: | ||
| pylint --rcfile=.pylintrc --exit-zero --fail-on=E customerio/analytics | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pylint CI never failsMedium Severity The new Reviewed by Cursor Bugbot for commit 7673d4e. Configure here.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| flake8 --max-complexity=10 --max-line-length=100 --statistics customerio/analytics | ||
|
|
||
| clean: | ||
| rm -rf .venv | ||
| mise deps | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clean target wrong mise commandMedium Severity The new Reviewed by Cursor Bugbot for commit c761e31. Configure here.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| .PHONY: install test lint lint-ci clean | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| import json | ||
| import time | ||
| import unittest | ||
|
|
||
| import mock | ||
| import time | ||
| import json | ||
|
|
||
| try: | ||
| from queue import Queue | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| VERSION = '0.0.2' | ||
| VERSION = '1.0.0' | ||
|
cursor[bot] marked this conversation as resolved.
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| backoff==2.2.1 | ||
| flake8==3.7.9 | ||
| monotonic==1.6 | ||
| mock==2.0.0 | ||
| pylint==3.3.3 | ||
| python-dateutil==2.8.2 | ||
| requests>=2.32.4 |


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like 3.8 & 3.9 are also eol https://endoflife.date/python should we remove those as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would keep these for now, since they are still available in GitHub runners.