Skip to content

Check pre conditions whenever tutorial resume is called #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreasArvidsson merged 1 commit into from
Sep 21, 2026
+6 −2
Merged

Check pre conditions whenever tutorial resume is called #3370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/lib-tutorial/src/TutorialImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,9 @@ export class TutorialImpl implements Tutorial, CommandRunnerDecorator {
return this.changeStep(() => 0);
}

resume() {
return this.setupStep();
async resume() {
await this.setupStep();
await this.checkPreconditions();
}

async list() {
Expand Down
3 changes: 3 additions & 0 deletions packages/test-vscode-e2e/src/suite/tutorial/tutorial.vscode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,9 @@ async function runBasicTutorialTest(spyIde: SpyIDE) {
// Test resuming tutorial
await commands.executeCommand("cursorless.tutorial.resume");
await checkStepSetup(fixtures[0]);
const resumedStateEvent = getTutorialWebviewEventLog().at(-2);
assert.ok(resumedStateEvent?.type === "messageSent");
assert.equal(resumedStateEvent.data.preConditionsMet, true);

// Test automatic advancing
await runCursorlessCommand({
Expand Down
Loading