Skip to content

feat: Add discovery output flags#107

Merged
twk3 merged 3 commits into
mainfrom
feat/add-discovery-output
May 14, 2026
Merged

feat: Add discovery output flags#107
twk3 merged 3 commits into
mainfrom
feat/add-discovery-output

Conversation

@twk3
Copy link
Copy Markdown
Contributor

@twk3 twk3 commented May 14, 2026

  • To make it clear these are for the pwc-p discovery subcommand

Summary by CodeRabbit

  • New Features

    • Added an extra-discovery-flags output that supplies --last-failed on re-runs to improve test discovery.
  • Documentation

    • Clarified API/orchestration mode setup, required environment variables, and documented the new extra-discovery-flags alongside existing flags.
  • Chores

    • Updated CI workflows to use newer Node.js versions for test runs.

Review Change Stack

- To make it clear these are for the pwc-p discovery subcommand
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0fdd6a42-0588-4fa8-8bd9-e2a3d2062dd2

📥 Commits

Reviewing files that changed from the base of the PR and between 2d6a835 and 1e249f5.

📒 Files selected for processing (1)
  • .github/workflows/test.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/test.yml

📝 Walkthrough

Walkthrough

Adds a new action output extra-discovery-flags (set to --last-failed when the orchestration API call succeeds), declares it in action.yml, sets it in src/index.ts, updates CI to exercise the output, and documents the output and orchestration re-run behavior in README.md. (≤50 words)

Changes

Discovery flags + CI + docs

Layer / File(s) Summary
Output declaration
action.yml
Adds new action output extra-discovery-flags with description for flags to pass to pwc-p discover.
Runtime behavior / action implementation
src/index.ts
When npx currents api get-run ... exits successfully, sets extra-discovery-flags to --last-failed in addition to existing outputs.
CI test jobs and verification
.github/workflows/test.yml
Updates actions/setup-node to Node.js 22 for test-action-sharding and test-action-or8n; test step for test-action-or8n reads steps.or8n_action.outputs.extra-discovery-flags into EXTRA_DISCOVERY_FLAGS and echoes it.
Documentation
README.md
Documents the new extra-discovery-flags output in the Outputs table and clarifies orchestration/re-run behavior and required env vars (CURRENTS_API_KEY, CURRENTS_PROJECT_ID) and or8n/use-api settings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • maxigimenez
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: Add discovery output flags' directly summarizes the main change: introducing a new output for discovery flags to clarify their purpose for the pwc-p discover command.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-discovery-output

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/test.yml:
- Around line 99-100: The env entry for EXTRA_DISCOVERY_FLAGS is currently a
nested mapping; change it to a scalar string so the workflow parser treats the
output value as a single env var. Replace the mapping-style value with a quoted
expression, e.g. set EXTRA_DISCOVERY_FLAGS: "${{
steps.or8n_action.outputs.extra-discovery-flags }}" (referencing
EXTRA_DISCOVERY_FLAGS and steps.or8n_action.outputs.extra-discovery-flags).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fd978f38-d7aa-4691-8cf9-1c772d9bcecd

📥 Commits

Reviewing files that changed from the base of the PR and between 560cffc and d6778ef.

⛔ Files ignored due to path filters (2)
  • badges/coverage.svg is excluded by !**/*.svg
  • dist/index.js is excluded by !**/dist/**
📒 Files selected for processing (4)
  • .github/workflows/test.yml
  • README.md
  • action.yml
  • src/index.ts

Comment thread .github/workflows/test.yml
@twk3 twk3 merged commit 319813c into main May 14, 2026
27 checks passed
@twk3 twk3 deleted the feat/add-discovery-output branch May 14, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant