feat: Add discovery output flags#107
Conversation
- To make it clear these are for the pwc-p discovery subcommand
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a new action output ChangesDiscovery flags + CI + docs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/test.yml:
- Around line 99-100: The env entry for EXTRA_DISCOVERY_FLAGS is currently a
nested mapping; change it to a scalar string so the workflow parser treats the
output value as a single env var. Replace the mapping-style value with a quoted
expression, e.g. set EXTRA_DISCOVERY_FLAGS: "${{
steps.or8n_action.outputs.extra-discovery-flags }}" (referencing
EXTRA_DISCOVERY_FLAGS and steps.or8n_action.outputs.extra-discovery-flags).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fd978f38-d7aa-4691-8cf9-1c772d9bcecd
⛔ Files ignored due to path filters (2)
badges/coverage.svgis excluded by!**/*.svgdist/index.jsis excluded by!**/dist/**
📒 Files selected for processing (4)
.github/workflows/test.ymlREADME.mdaction.ymlsrc/index.ts
Summary by CodeRabbit
New Features
Documentation
Chores