Skip to content

Prefer Pickle.Location with fallback to Lineage#175

Merged
davidjgoss merged 2 commits into
mainfrom
pickle-location
Jun 25, 2026
Merged

Prefer Pickle.Location with fallback to Lineage#175
davidjgoss merged 2 commits into
mainfrom
pickle-location

Conversation

@davidjgoss

@davidjgoss davidjgoss commented Jun 17, 2026

Copy link
Copy Markdown
Member

🤔 What's changed?

Pickle.Location is present in newer versions of Cucumber, so if it's there we should use it rather than go through the Lineage to get it. We should still maintain the fallback though, since Query will be used for formatters that might still be dealing with messages from older versions.

(This brings the .NET and JavaScript versions in line with what Java was already doing.)

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss marked this pull request as ready for review June 18, 2026 07:39
Comment thread dotnet/Cucumber.QueryTest/QueryTest.cs

@mpkorstanje mpkorstanje left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@davidjgoss davidjgoss merged commit e71d61f into main Jun 25, 2026
9 checks passed
@davidjgoss davidjgoss deleted the pickle-location branch June 25, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants