docs(config): fix keyring template so set_password matches lookup#167
Open
nicolasbisurgi wants to merge 1 commit into
Open
docs(config): fix keyring template so set_password matches lookup#167nicolasbisurgi wants to merge 1 commit into
nicolasbisurgi wants to merge 1 commit into
Conversation
The example command stored the secret under service `'TM1py'` and account `<instance>`, but `tm1_integration.resolve_tm1_params` looks it up as `keyring.get_password(<instance>, <user>)`. Users who copied the template verbatim got the fallback warning and an empty password. Also documents the missing `use_keyring=true` step — keyring is opt-in per section, and the previous template didn't say so. Code path unchanged; docs only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
|
Would it be possible to add a run mode where RushTI reads the password from the config.ini file and stores it in the Windows Credential Manager using Keyring? The main use case is environments where the TM1 Service runs under a dedicated service account. In those cases, the Windows Credential Manager is account-specific, so the password has to be registered manually for that account. Having RushTI perform this step automatically would make the initial setup much simpler and avoid the need for manual intervention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation-only fix.
config/config.ini.templateshowed akeyring.set_passwordcommand that stored the secret under aservice/account combination RushTI never queries.
Code lookup (
src/rushti/tm1_integration.py:93):keyring.get_password(<instance_name>, <user>)Old template:
keyring.set_password('TM1py', 'tm1srv01', 'mypassword')— stored underservice
'TM1py', account<instance>. Never matched.Fixed template:
keyring.set_password('<instance>', '<user>', 'mypassword')— nowmatches what the code reads.
Also documents the missing
use_keyring=truestep; keyring is opt-inper section and the previous template omitted that.
No runtime change; template comment only.
Test plan
config.ini, adduse_keyring=true, run theupdated
keyring.set_passwordcommand, launchrushti run ...,confirm connection succeeds without the "no password found in
keyring" warning.
still fires (proves the old template was wrong).
🤖 Generated with Claude Code