fix(deps): float handlebars, form-data and tar to clear two criticals - #11549
fix(deps): float handlebars, form-data and tar to clear two criticals#11549bsod90 wants to merge 1 commit into
Conversation
Lockfile-only. Three descriptors already admitted the patched versions; the lockfile was just stale. Deleted those blocks and re-resolved, leaving everything else untouched (24 insertions, 37 deletions). handlebars ^4.7.7 4.7.7 -> 4.7.9 CLOSES #7891 form-data ^2.3.1, ^2.5.0 2.5.1 -> 2.5.6 CLOSES #7589 tar ^7.4.0/^7.4.3/^7.5.2 7.4.3, 7.5.2 -> 7.5.22 (partial) form-data's 4.x copy is untouched: the advisory is `< 2.5.4`, so 4.0.5 was never affected. Note the open PR #11109 bumps 4.0.5 -> 4.0.6, which is the wrong copy and does not close #7589. tar does NOT close. Two vulnerable resolutions remain and neither can float: tar@7.5.11 an EXACT pin from lerna@^9.0.7 tar@6.2.1 the ^6.x cluster, a major boundary So this takes tar from five vulnerable resolutions to two; #8252 stays open pending a lerna bump or an override. Verified: no version downgraded (removed 2.5.1/4.7.7/7.4.3/7.5.2, added 2.5.6/4.7.9 plus hasown 2.0.4 as a new transitive), and `yarn install --frozen-lockfile` succeeds, which is the consistency gate CI applies. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Claude finished @bsod90's task in 1m 45s —— View job Review: LGTM — lockfile changes check out. 0 blocking, 1 nit.Full review
What I verifiedNo downgrades, no collateral moves. Every version delta in the diff is upward: No dangling descriptors. I grepped for every descriptor removed from a block header to confirm nothing still depends on it:
And the deps that the deleted
Five → two is accurate, and leaving #8252 open rather than claiming a close is the right call.
Install consistency — I did not run a full Findings1 nit, posted inline: the new Optional follow-up for #8252The root |
| hasown@^2.0.4: | ||
| version "2.0.4" | ||
| resolved "https://registry.yarnpkg.com/hasown/-/hasown-2.0.4.tgz#8c62d8cb90beb2aad5d0a5b67581ad9854c3f003" | ||
| integrity sha512-T2UbfbBEF32wiepXIsMlTW9+dDYC6wMh/t/vYA4tuOMKqWz/n3vr1NFSxQiyP+zk2mXsoMA/i/7qV6LKut1t1A== | ||
| dependencies: | ||
| function-bind "^1.1.2" |
There was a problem hiding this comment.
Nit (dedupe): this creates a second hasown copy — the existing block at line 14847 (hasown@^2.0.0, hasown@^2.0.2) still resolves to 2.0.2, and ^2.0.4 doesn't fit that range so yarn split it out. Since 2.0.4 satisfies ^2.0.0 and ^2.0.2 too, deleting the old block and letting all three descriptors collapse onto 2.0.4 would keep one copy instead of two:
hasown@^2.0.0, hasown@^2.0.2, hasown@^2.0.4:
version "2.0.4"
Purely cosmetic — no correctness impact, and not worth a re-resolve on its own if you'd rather keep the diff minimal.
true
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11549 +/- ##
=======================================
Coverage 59.35% 59.35%
=======================================
Files 223 223
Lines 17989 17989
Branches 3641 3641
=======================================
Hits 10677 10677
Misses 6793 6793
Partials 519 519
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Lockfile-only, +24 / −37. Three descriptors already admitted the patched versions —
the lockfile was simply stale. I deleted only those blocks and re-resolved, so nothing
else moved.
handlebars^4.7.7form-data^2.3.1, ^2.5.0tar^7.4.0,^7.4.3,^7.5.2Two notes worth catching
form-data's 4.x copy is deliberately untouched. The advisory is< 2.5.4, so4.0.5was never affected. The already-open #11109 bumps 4.0.5 → 4.0.6 — the wrongcopy — and does not close #7589.
tardoes not close, and I don't want to imply otherwise. Two vulnerableresolutions remain, neither floatable:
This takes tar from five vulnerable resolutions to two. #8252 stays open pending
a lerna bump or an override.
Verification
hasown@2.0.4as a new transitiveyarn install --frozen-lockfilesucceeds — the consistency gate CI appliestar7.x descriptors collapsed onto 7.5.22, a version already present and proven elsewhere in the treeAll three are patch/minor moves within ranges the packages already declare, so no
consumer sees an API change.
🤖 Generated with Claude Code