Skip to content

docs: correct the small multiples grid maximum to 5 × 5 - #11498

Open
igorlukanin wants to merge 1 commit into
masterfrom
igor/core-750-small-multiples-docs-grid-5x5
Open

docs: correct the small multiples grid maximum to 5 × 5#11498
igorlukanin wants to merge 1 commit into
masterfrom
igor/core-750-small-multiples-docs-grid-5x5

Conversation

@igorlukanin

Copy link
Copy Markdown
Member

The small multiples page says the grid goes up to 5 × 4 and that the largest grid is twenty panels. Both maxima are 5: MAX_GRID_COLUMNS = 5 and MAX_GRID_ROWS = 5, and the control renders a fifth row segment.

Since the grid is also the panel cap (columns × rows tiles, no separate cap), the largest grid is 5 × 5 — twenty-five panels, not twenty.

Two spots corrected: the Grid row of the options table, and the "How many panels are drawn" section.

@igorlukanin
igorlukanin requested a review from keydunov as a code owner August 7, 2026 00:41
@mintlify

mintlify Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview Aug 7, 2026, 12:42 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@claude

claude Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 34s —— View job


Review: approve — no issues found

Two-line docs correction; both edits are consistent and no other page repeats the stale numbers.

Details
  • Gather context (read diff and full page)
  • Verify the claim and check for other stale mentions
  • Check for existing review threads
  • Post review

What changed

docs-mintlify/docs/explore-analyze/charts/configuration/small-multiples.mdx

  • L26 (options table, Grid row): up to 5 × 4up to 5 × 5
  • L41 (How many panels are drawn): The largest grid is 5 × 4, or twenty panels.5 × 5, or twenty-five panels.

Checks

Check Result
Arithmetic 5 × 5 = 25 ✅ — the spelled-out "twenty-five" matches
Internal consistency Both spots that stated a maximum were updated; the 3 × 2 → six panels example on L41 is independent of the max and remains correct
Other stale mentions grep across docs-mintlify/ for 5 × 4, 5x4, twenty panels returns nothing outside this file — no follow-up edits needed
Style × (U+00D7) used consistently, matching the rest of the page; number words spelled out as elsewhere in the paragraph
Nav / frontmatter Untouched, so no docs.json update needed
Deprecated docs site No changes under /docs — correct per CLAUDE.md

One note, not a blocker

The underlying MAX_GRID_COLUMNS / MAX_GRID_ROWS constants aren't in this repo (chart controls live in the Cube Cloud frontend), so I verified the change for internal consistency and cross-page consistency rather than against the source. Taking the PR description's MAX_GRID_ROWS = 5 at face value, the edit is right.

Nothing to flag on security, performance, or testing — the diff is prose only.

· [`igor/core-750-small-multiples-docs-grid-5x5`](https://github.com/cube-js/cube/tree/igor/core-750-small-multiples-docs-grid-5x5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant