Add visible configuration prompts - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The configuration screens did not explain how to change or save values. During hardware validation, the new prompts and existing black labels were also found to be invisible because the font blitter used black as its transparency key. After palette mapping, this discarded black foreground glyphs along with transparent background pixels.
Impact
Configuration screens now show
Swipe L/R to changeandSwipe UP: save. Black labels render correctly throughout the firmware instead of disappearing.Validation
python -m unittest discover -s tests -v- 63 tests passed