Handle unavailable touch and IMU hardware - #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The QMI8658 driver returned an undefined
NULLvalue for an unexpected chip ID, the touch driver could return a partially initialized object, and startup constructed the IMU even when Launch Mode was disabled. Missing or incompatible hardware could therefore produce undefined-name errors or later crashes.Impact
The required touchscreen now either initializes completely or stops safely after bounded retries. The optional IMU can fail without preventing standard swipe-down timing, while serial and on-screen messages explain the hardware problem.
Validation
python -m unittest discover -s tests -v- 59 tests passedCloses #11