Fix configuration persistence and add host tests - #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Configuration values were selected and updated using fixed indexes and truthiness checks, so opening an editor reset its value and
SENSITIVITY=0corrupted the in-memory settings object. JSON writes truncated the active file before serialization and unvalidated keys were injected into globals. Hardware imports also prevented normal host-side regression testing.User impact
Track/rest selections now reopen at their saved values, Launch Mode can be disabled persistently, damaged or legacy configuration is recovered into safe canonical values, and future changes receive automated host-side coverage.
Physical LCD, touch, IMU, pinout, and real-world launch threshold behavior remain outside host test coverage.
Validation
python3 -m unittest discover -s tests -q— 23 tests passedgit diff --checkCloses #6
Closes #7
Closes #8
Closes #9
Closes #12