build: bump setuptools from 83.0.0 to 84.0.0 in /requirements - #759
Open
blaipr wants to merge 1 commit into
Open
build: bump setuptools from 83.0.0 to 84.0.0 in /requirements#759blaipr wants to merge 1 commit into
blaipr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Bumps
setuptoolsfrom83.0.0to84.0.0inrequirements/requirements.txt. It is the build backend the image uses for every source distribution it installs.The Python requirements are outside Dependabot's scope on purpose: #675 turned on version updates for github-actions and for npm in
/awx/uiand left this file out, because it is compiled byrequirements/updater.shrather than hand-pinned. So this was produced the same waymake requirementsproduces it:run inside the
ascender_develimage, which is where that script insists on running. Pinned with==inrequirements.in, soupgradecannot move it: the pin is edited first andrunrecompiles against it. The result is 1 added / 1 removed in each of the two files.The
# CVE-2026-59890comment is deliberately kept on the pin. 83.0.0 is where that fix landed, so 84.0.0 stays above it and the reason for pinning still reads true; the comment would only be wrong if the pin ever moved down.Like the other build-toolchain bumps in this batch, the unit suite passing says less here than it does for a library: setuptools is exercised when the image builds a source distribution, not by the tests. The real check is a green image build, which happens once the workflow is approved on this fork pull request.
ISSUE TYPE
COMPONENT NAME
ASCENDER VERSION
Tests
Tested before opening, in the same image, with
setuptools 84.0.0installed into the AWX venv:CI does not run on pull requests from a fork until a maintainer approves the workflow, so this is what stands behind the change until then.