[codex] Add bounded markup motion hooks#574
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a46a978c48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| done(); | ||
| }; | ||
| motionEndEvents.forEach((eventName) => node.addEventListener(eventName, finish)); | ||
| timer = setTimeout(finish, motionFallbackMS); |
There was a problem hiding this comment.
Do not truncate user-defined motion durations
When a user-defined transition or animation lasts longer than 240ms, this timeout fires before the browser's transitionend/animationend, which clears the motion classes and removes leaving nodes early. The new docs say motion timing lives in user/addon CSS and do not impose a duration cap, so a normal transition: opacity 500ms leave animation would be cut off at 240ms. Compute the fallback from the element's computed transition/animation durations and delays, or otherwise avoid letting the fallback preempt real end events.
Useful? React with 👍 / 👎.
Summary
g:transition/g:animatefor enter/leave animations #503.g:transitionandg:animatedirectives for clientg:ifbranches and keyed clientg:forrows.Verification
go test ./internal/viewparse ./internal/viewrender ./internal/viewanalysis ./internal/clientrt ./internal/buildgen ./internal/lang ./internal/diagnosticsgo build ./cmd/gowdkgo test ./...scripts/test-go-modules.sh