Skip to content

[codex] Add bounded markup motion hooks#574

Merged
cssbruno merged 1 commit into
mainfrom
codex/issue-503-transitions
Jun 20, 2026
Merged

[codex] Add bounded markup motion hooks#574
cssbruno merged 1 commit into
mainfrom
codex/issue-503-transitions

Conversation

@cssbruno

Copy link
Copy Markdown
Owner

Summary

  • Fixes [Markup] Bounded g:transition/g:animate for enter/leave animations #503.
  • Adds bounded g:transition and g:animate directives for client g:if branches and keyed client g:for rows.
  • Emits motion data attributes and toggles compiler-owned enter/leave/move classes in the island runtime, including interrupted leave handling.
  • Updates docs, stability metadata, diagnostics text, conformance coverage, and the feature spec/plan.

Verification

  • go test ./internal/viewparse ./internal/viewrender ./internal/viewanalysis ./internal/clientrt ./internal/buildgen ./internal/lang ./internal/diagnostics
  • go build ./cmd/gowdk
  • go test ./...
  • scripts/test-go-modules.sh

@cssbruno cssbruno marked this pull request as ready for review June 20, 2026 19:44
@cssbruno cssbruno merged commit 95362af into main Jun 20, 2026
16 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a46a978c48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

done();
};
motionEndEvents.forEach((eventName) => node.addEventListener(eventName, finish));
timer = setTimeout(finish, motionFallbackMS);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not truncate user-defined motion durations

When a user-defined transition or animation lasts longer than 240ms, this timeout fires before the browser's transitionend/animationend, which clears the motion classes and removes leaving nodes early. The new docs say motion timing lives in user/addon CSS and do not impose a duration cap, so a normal transition: opacity 500ms leave animation would be cut off at 240ms. Compute the fallback from the element's computed transition/animation durations and delays, or otherwise avoid letting the fallback preempt real end events.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Markup] Bounded g:transition/g:animate for enter/leave animations

1 participant