Skip to content

Getting_Started updated with working transport1D.cpp code#407

Open
jbrzensk wants to merge 1 commit into
mainfrom
bug/compile_example
Open

Getting_Started updated with working transport1D.cpp code#407
jbrzensk wants to merge 1 commit into
mainfrom
bug/compile_example

Conversation

@jbrzensk

@jbrzensk jbrzensk commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Example
  • Documentation

Description

Code in getting started compiles correctly with MOLE library.

Related Issues & Documents

QA Instructions, Screenshots, Recordings

 examples/cpp/example 
   1.0000e+00
   9.9012e-01
   9.5237e-01
   8.8441e-01
   7.8370e-01
   6.5629e-01
   5.1576e-01
   3.7869e-01
   2.5923e-01
   1.6534e-01
   9.8320e-02
   5.4581e-02
   2.8338e-02
   1.3787e-02
   6.2998e-03
   2.7092e-03
   1.0989e-03
   4.2129e-04
   1.5295e-04
   5.2687e-05
   1.7251e-05
   5.3776e-06
   1.5986e-06
   4.5385e-07
   1.2324e-07
   3.2192e-08
   9.8869e-09
   9.8869e-09

Copilot AI review requested due to automatic review settings July 2, 2026 17:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the C++ “Getting Started” quick-start snippet (transport1D.cpp) so it matches the working MOLE C++ example and compiles as a self-contained program.

Changes:

  • Adds missing simulation parameters (m, iter, dt, dis, vel, R, C0) to eliminate undeclared-variable compile errors.
  • Adds initial conditions and time-stepping details (including dispersion/retardation scaling and a right boundary condition) to make the snippet runnable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread doc/sphinx/source/intros/gettingstarted.md
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting Started C++ quick-start snippet does not compile (undeclared iter, dt, dis)

2 participants