Getting_Started updated with working transport1D.cpp code#407
Open
jbrzensk wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the C++ “Getting Started” quick-start snippet (transport1D.cpp) so it matches the working MOLE C++ example and compiles as a self-contained program.
Changes:
- Adds missing simulation parameters (
m,iter,dt,dis,vel,R,C0) to eliminate undeclared-variable compile errors. - Adds initial conditions and time-stepping details (including dispersion/retardation scaling and a right boundary condition) to make the snippet runnable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Code in getting started compiles correctly with MOLE library.
Related Issues & Documents
QA Instructions, Screenshots, Recordings