Remove elliptic1DaddScalarBC.m#405
Open
jbrzensk wants to merge 3 commits into
Open
Conversation
jbrzensk
added
the
Examples
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a redundant MATLAB/Octave elliptic PDE example (elliptic1DaddScalarBC.m) in favor of the already-existing Robin/Robin example, keeping the simpler elliptic1D.m example as the minimal reference.
Changes:
- Deleted
examples/matlab_octave/elliptic1DaddScalarBC.m(duplicative Robin/Robin example).
Comments suppressed due to low confidence (1)
examples/matlab_octave/elliptic1DaddScalarBC.m:1
- This file is being removed, but the Sphinx docs still link to it (doc/sphinx/source/examples/Elliptic/1D/Elliptic1D-add-Scalar-BC.md:45). After this merge, that link will be broken; please update the docs to remove/replace the MATLAB/OCTAVE link (e.g., point to elliptic1DLeftRobinRightRobin.m if that’s the intended replacement).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
doc/sphinx/source/examples/Elliptic/1D/Elliptic1D-add-Scalar-BC.md:1
- This page is being removed, but the Sphinx toctree still references
Elliptic1D-add-Scalar-BC(doc/sphinx/source/examples/Elliptic/1D/index.md:9). As-is, the docs build will fail with a missing toctree entry; either remove that entry from the index or keep a stub page redirecting to an existing Robin BC example (e.g., Elliptic1D-Left-Robin-Right-Robin).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
elliptic1DaddScalarBC.m was an example showing how to use addScalarBCs. It does Robin BC on each end. There is already an example for this (ellipic1DLeftRobinRightRobin.m). Removing seems the cleanest option. elliptic1D.m is kept, as the simplest (in terms of lines of code) example solving an elliptic pde.
Related Issues & Documents
elliptic1DaddScalarBC.mexample #386