Fix unresponsive UI after pressing back on the unlock screen, fixes #648

[SailReal]

fixes #648

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d530e536-e8f0-42b0-aab5-b2040312f061

📥 Commits

Reviewing files that changed from the base of the PR and between b16f6e4 and 4afe0bf.

📒 Files selected for processing (8)

• presentation/src/main/java/org/cryptomator/presentation/ui/dialog/BiometricAuthKeyInvalidatedDialog.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/dialog/ChangePasswordDialog.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/dialog/CreateHubDeviceDialog.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/dialog/EnterPasswordDialog.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/dialog/HubLicenseUpgradeRequiredDialog.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/dialog/HubUserSetupRequiredDialog.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/dialog/HubVaultAccessForbiddenDialog.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/dialog/HubVaultArchivedDialog.kt

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

Walkthrough

Eight dialogs now handle cancellation through onCancel instead of custom KEYCODE_BACK listeners. Each dialog preserves its cancellation callback, and EnterPasswordDialog also closes the dialog through its callback. The unused KeyEvent imports and manual dismissal code were removed.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 24 functions across 8 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided, so the change context and implementation details are not documented.	Add a concise description that explains the dialog cancellation changes and how they fix the unresponsive UI after pressing Back on the unlock screen.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly describes the primary change: fixing unresponsive UI after pressing Back on the unlock screen. This matches the dialog cancellation changes in the pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}