WAF: add custom HTTP server#4472
Conversation
|
@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@blotus: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4472 +/- ##
==========================================
+ Coverage 63.89% 64.00% +0.11%
==========================================
Files 478 482 +4
Lines 34298 34736 +438
==========================================
+ Hits 21915 22234 +319
- Misses 10227 10317 +90
- Partials 2156 2185 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The current implementation relies on the standard
net/httpserver, which is pretty opinionated about what a request should look like.This can cause the appsec datasource to refuse to analyze some requests that are technically invalid according to the RFC, but still processed by other web servers.
This PR replace the
net/httpserver with a custom one that avoid rejecting requests.Proper fix would be to move away from HTTP for the appsec protocol, but this would require a lot of breaking changes.
Once this PR is merged, we'll still need to rethink the way requests are serialized to better split the transport layer with the data layer.