fix workflows - #205
Open
davidabram wants to merge 22 commits into
Open
Conversation
Generated workflow packages cited support and synchronization documents that were missing from their package-local inventories, leaving references unresolvable across targets. Add the missing commit and sync-report documents, replace stale validation-result references with the emitted output document, and update the derived coverage and artifact-count contracts so the package shape remains complete and deterministic. Plan: emit-composite-workflow-references Tasks: T01, T02 Co-authored-by: SCE <sce@crocoder.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Validation emitted an obsolete sync-report reference and carried stale artifact inventory expectations after the validation package was consolidated. Remove the redundant output, align the package coverage and artifact-count expectations with the current shape, and record the completed work in the plan and architecture documentation. Plan: workflow-skill-boundary-cleanup Task: T01 Co-authored-by: SCE <sce@crocoder.dev>
The next-task and validate workflows need durable lifecycle state to prevent unresolved synchronization debt from being lost at session boundaries. Persist pending, synced, and blocked states in plans, gate new work and plan completion on synced state, and retain blocker details for retries. Plan: workflow-skill-boundary-cleanup Task: T03 Co-authored-by: SCE <sce@crocoder.dev>
The workflow previously described one ambiguous continuation shape, making clarification resumes vulnerable to re-requesting the original change. Distinguish initial clarification from existing-plan revision and preserve the required fields across generated instructions and shared workflow documentation. Plan: workflow-skill-boundary-cleanup (T04) Co-authored-by: SCE <sce@crocoder.dev>
Final validation previously removed temporary scaffolding, which could hide unfinished artifacts and mutate the state being measured. Remove cleanup instructions and successful-report fields, and record leftover debug or temporary artifacts as failed evidence instead. Keep the related workflow documentation aligned. Plan: workflow-skill-boundary-cleanup (T05) Co-authored-by: SCE <sce@crocoder.dev>
Next-task execution now captures a pre-edit Git baseline and reports only task-caused changed paths, while requiring complete implementation and verification handoff evidence. The receiving phase consumes that authoritative attribution and blocks incomplete or contradictory handoffs while preserving the mandatory five-root-file checks.\n\nPlan: `workflow-skill-boundary-cleanup`\nTask: `T06` Co-authored-by: SCE <sce@crocoder.dev>
Handover writer mode now includes staged diffs in repository evidence, while loader mode rejects required sections that are empty or still contain template scaffolding. Move the persisted format into a package-local template and update generated path contracts so all targets expose it. Plan: workflow-skill-boundary-cleanup (T07) Co-authored-by: SCE <sce@crocoder.dev>
The commit workflow now embeds commit-message rules and the atomic-commit result contract in `references/atomic-commit.md`, removing obsolete generated reference files and their inventory entries. Updates the artifact-count and metadata checks plus workflow documentation to reflect the smaller package. Plan: workflow-skill-boundary-cleanup, T08 Co-authored-by: SCE <sce@crocoder.dev>
Multiline commit messages were previously passed through an underspecified execution path, and the hash-reporting and failure rules were not explicit across the workflow references. Require verbatim message-file transport, exactly one `git commit -F` invocation, and explicit post-success HEAD hash retrieval while preserving the no-retry and no-additional-staging guarantees. Plan: workflow-skill-boundary-cleanup, T09 Co-authored-by: SCE <sce@crocoder.dev>
Decision writing treated ordinary nonqualifying requests as blockers and left ADR reuse and status-history rules ambiguous, which could stop successful workflow completion or revive obsolete records. Distinguishes non-blocking `not_qualified`/`skipped` outcomes from genuine blockers, keeps all ADRs immutable, permits reuse only for active `Proposed`/`Accepted` records, and records changed decisions as new dated ADRs while retaining `Deprecated` and `Superseded` as creation-time statuses. This preserves auditable decision history and lets callers continue after nonqualifying gates. Plan: `workflow-skill-boundary-cleanup` (T10) Co-authored-by: SCE <sce@crocoder.dev>
The shared composite preamble overstated which workflows support clarification, validation-repair, and bootstrap waits. Replace that universal wording with a generic statement covering only workflow-defined waits, while preserving each workflow’s specific semantics and updating the supporting documentation. Plan: workflow-skill-boundary-cleanup (T11). Co-authored-by: SCE <sce@crocoder.dev>
Generated workflow output previously relied on inventory checks for several semantic invariants, allowing invalid layout citations, stale references, target drift, and non-observational validation wording to escape detection.\n\nAdds nine independent contract assertions with negative fixtures, registers them in the generated-output harness and flake inputs, and documents the resulting guarantees across repository context. Completes plan workflow-skill-boundary-cleanup task T12.\n\nPlan: workflow-skill-boundary-cleanup (T12) Co-authored-by: SCE <sce@crocoder.dev>
OpenCode permissions were validated for ordering but not that each explicit allow mapped to an emitted skill artifact. Add a contract assertion for both agents, register a dangling-permission fixture, and update the related checks and records so generation validation catches stale permission names. Plan: workflow-skill-boundary-cleanup; tasks T01, T02, T13. Co-authored-by: SCE <sce@crocoder.dev>
Generated skill references still pointed at the generic validation output path, which no longer defines the validation result contract. Aligns the Claude, OpenCode, and Pi skill trees with the dedicated validation-result reference and removes the obsolete sync-report link.
Workflow completion records now retain the handoff needed to recover pending or blocked synchronization across sessions, while next-task and context-sync share the persisted retry contract. Reconcile bypass commit temp-file rules and make layout-reference checks resolve the cited document, with fixtures covering the new generation guarantees. Clarify lifecycle values and update the canonical workflow documentation. Plan: sync-handoff-recovery-and-generation-fixes (T01-T06) Co-authored-by: SCE <sce@crocoder.dev>
Align Claude, OpenCode, and Pi skill instructions around durable handoffs, synchronization debt, and validation reporting. Reorder the Claude hook configuration so tool policy runs before post-tool tracing while preserving agent tracing.
Plan review now detects unresolved debt across every completed task, while the top-level workflow owns recovery, lifecycle updates, and blocked-result routing. Persisted handoffs carry plan and task identity, and generation-contract fixtures protect the new behavior across targets. Plan: next-task-sync-debt-recovery-refactor; Tasks: T01, T02, T03, T04, T05, T06 Co-authored-by: SCE <sce@crocoder.dev>
Align the Claude, OpenCode, and Pi SCE skill trees around shared output layouts and embedded document formats. Remove obsolete synchronization handoff rules and stale reference content while preserving the composite workflow behavior across targets.
Make `/validate` finish with validation reporting while canonicalizing `/commit` message-style ownership. Update target skill payloads, renderer inventories, and durable workflow documentation so generated behavior remains consistent and deterministic. Plan: remove-validate-context-sync (T01, T02, T03, T04) Co-authored-by: SCE <sce@crocoder.dev>
Keep Bash policy enforcement in Claude's pre-tool hook while preserving trace hooks for tool completion and prompt lifecycle events. Remove duplicated validation context-sync references from the generated assistant target trees because the workflow now owns that behavior centrally. Also normalize the OpenCode plugin configuration without changing its plugin set.
Align canonical Pkl sources, generation contracts, and durable workflow documentation so `/validate` records final validation evidence without owning a plan-level lifecycle. Narrow `sce-decision` invocation to `/next-task`, remove obsolete template wording, and add a negative generation fixture for the boundary. Plan: context/plans/remove-validate-context-sync.md (T01-T08) Co-authored-by: SCE <sce@crocoder.dev>
Align validation descriptions across Claude, OpenCode, and Pi with the final-evidence workflow, remove plan-level state from templates, and restrict decision records to task verification. Normalize generated hook and config ordering for consistent targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.