fix: make pre-commit hooks cross-platform (Windows) - #6983
Open
RajeshShrirao wants to merge 1 commit into
Open
Conversation
Replace bash -c 'source .venv/bin/activate && ...' wrappers with plain uv run invocations. The Unix-only activation script (.venv/bin/activate) does not exist on Windows (.venv\Scripts\activate is used instead), so ruff, ruff-format, mypy, and pip-audit never executed on Windows. uv run already activates the project virtual environment, making the explicit source step redundant on all platforms. Fixes crewAIInc#6863
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesPre-commit hook execution
Suggested reviewers: Mergeability Score: ⚪ Minimal · up to This localized configuration change makes the pre-commit hooks cross-platform without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6863 — pre-commit hooks (ruff, ruff-format, mypy, pip-audit) failed on Windows before executing because they wrapped every command in:
bash -c 'source .venv/bin/activate && uv run ...' --.venv/bin/activateis Unix-only; Windows virtual environments use.venv\\Scripts\\activate.Change
Dropped the
bash -c 'source .venv/bin/activate && ...'wrapper entirely and invokeuv rundirectly, which already activates the project virtual environment on every platform:uv run ruff check --config pyproject.tomluv run ruff format --config pyproject.tomluv run mypy --config-file pyproject.tomluv run pip-audit --skip-editable ...Why this is safe
uv runresolves and activates the project env itself — the explicitsourcewas redundant on POSIX too.Verification
ruff check/ruff format --checkrun with the new entry shape.