Skip to content

chore(telemetry): remove unused _safe_telemetry_operation from crewai_core - #6977

Open
Vidit-Ostwal wants to merge 4 commits into
mainfrom
chore/remove-unused-safe-telemetry-operation
Open

chore(telemetry): remove unused _safe_telemetry_operation from crewai_core#6977
Vidit-Ostwal wants to merge 4 commits into
mainfrom
chore/remove-unused-safe-telemetry-operation

Conversation

@Vidit-Ostwal

Copy link
Copy Markdown
Contributor

Summary

  • Remove unused _safe_telemetry_operation from lib/crewai-core/src/crewai_core/telemetry.py.
  • In crewai_core, this method was only defined and never called. The class uses _safe_telemetry_procedure instead.
  • There is a same-named method on the older Telemetry in lib/crewai/src/crewai/telemetry/telemetry.py that is still in use; this PR does not touch that path or any tests.

Test plan

  • Confirm _safe_telemetry_operation has no call sites under lib/crewai-core
  • Confirm existing telemetry tests still pass without changes

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9a1c1a15-64bb-439e-a9f2-2e76df1919df

📥 Commits

Reviewing files that changed from the base of the PR and between 754d732 and b6b1bf9.

📒 Files selected for processing (1)
  • lib/crewai-core/src/crewai_core/telemetry.py
💤 Files with no reviewable changes (1)
  • lib/crewai-core/src/crewai_core/telemetry.py

📝 Walkthrough

Walkthrough

The telemetry module removes the private _safe_telemetry_operation helper. The _safe_telemetry_procedure helper remains for void telemetry procedures.

Changes

Telemetry behavior

Layer / File(s) Summary
Remove span-operation helper
lib/crewai-core/src/crewai_core/telemetry.py
Removes _safe_telemetry_operation and its failure-swallowing behavior for span-returning operations.

Merge Risk: ⚪ Minimal · up to b6b1b

This change removes an unused telemetry helper without altering the active telemetry path; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately explains the removal of the unused helper and identifies the unchanged legacy telemetry path.
Title check ✅ Passed The title clearly and concisely identifies the removal of the unused telemetry helper.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-unused-safe-telemetry-operation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant