[DISCARDED] Fix: Add timeout to network requests to prevent infinite hangs - #295
Closed
pranjal2004838 wants to merge 1 commit into
Closed
pranjal2004838 wants to merge 1 commit into
pranjal2004838 wants to merge 1 commit into
Conversation
pranjal2004838
requested review from
TimidRobot and
possumbilities
and removed request for
a team
May 18, 2026 08:18
Member
TimidRobot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where network requests can cause infinite hangs in CI/CD pipelines.
Changes:
timeout=30parameter torequests.get()calls in bothscripts/1-fetch/github_fetch.pyandscripts/1-fetch/smithsonian_fetch.py.Reasoning:
By default, Python's
requestslibrary uses an infinite timeout. If the remote API server accepts a connection but fails to send data, the script will hang forever, waiting for a response and burning pipeline minutes. Setting a 30-second timeout ensures that instead of freezing endlessly, it will raise a timeout exception if the external server becomes unresponsive.