Patches related to fix some bugs & some existed feature behaviour fixes#173
Open
userariii wants to merge 213 commits intocrdroidandroid:16.0from
Open
Patches related to fix some bugs & some existed feature behaviour fixes#173userariii wants to merge 213 commits intocrdroidandroid:16.0from
userariii wants to merge 213 commits intocrdroidandroid:16.0from
Conversation
Remove key of enrollAfterFace in FaceEnroll if this intent is coming from external package Bug: 433252423 Flag: EXEMPT BUGFIX Test: atest FaceEnrollTest (cherry picked from commit 7ac22f2eae5d3e8e65bc7f8db5a173231ebba071) Cherrypick-From: https://googleplex-android-review.googlesource.com/q/commit:c602fa951f06c4ae8b3fa4653e545fecd3e87193 Merged-In: Ibbb6340163613ea955516f11579d767b2ade4312 Change-Id: Ibbb6340163613ea955516f11579d767b2ade4312
Bug: 430047417 Test: manual test Flag: EXEMPT BUGFIX (cherry picked from commit bd4d57ade07792f2a9160acbe480603b30e79917) Cherrypick-From: https://googleplex-android-review.googlesource.com/q/commit:2860bd01810adb2d0f00fba8f327cdae3f20ab9d Change-Id: I91dafa77d07970fdf2628b4d9e89ca1c4b74194c Merged-In: I91dafa77d07970fdf2628b4d9e89ca1c4b74194c
If the new settings key is not set, we should use the values of the old
keys as default value.
Bug: 444673089
Test: atest FaceSettingsAppsPreferenceControllerTest
FaceSettingsKeyguardUnlockPreferenceControllerTest
FingerprintSettingsAppsPreferenceControllerTest
FingerprintSettingsKeyguardUnlockPreferenceControllerTest
Flag: EXEMPT BUGFIX
(cherry picked from commit 05f0884146a093e6311d7a30232d6850a28368ef)
Cherrypick-From: https://googleplex-android-review.googlesource.com/q/commit:feb931006ee2d56c146156d5bb1491117841ccf3
Merged-In: I345defc78500c244e29e8595f5fbc705b95f4ba6
Change-Id: I345defc78500c244e29e8595f5fbc705b95f4ba6
Since the POLICY_ALLOW_METERED_BACKGROUND and POLICY_REJECT_METERED_BACKGROUND
bit flags are mutually exclusive we should remove the opposite flag
from the cached policy entry on update.
Luckily this code only cares about those two specific flags so
we can easily work assuming we live in such sandbox.
The only difference we have to take into account is at "toggle"
time to use the {add,remove}UidPolicy that automatically
handles bit fiddling for us.
Change-Id: Ifd8a0c8393cfc5da3c31244c2780189aedd40210
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Co-authored-by: 306bobby-android <143777624+306bobby-android@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I72c90ae2f66eb1d6a9c6a423f50ea9df626559d2 Signed-off-by: Joey Huab <joey@evolution-x.org> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* Rather ugly Drop Down Signed-off-by: Pranav Vashi <neobuddy89@gmail.com> Signed-off-by: Joey Huab <joey@evolution-x.org> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I34c21377840ec8a298f3c49e03445151eecc3ec4 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
This seems kinda empty... Fill it with fun stuff Change-Id: Ia43cb31b7567bed07f2b8a1d8637de4e66320c90 [jaysonedson@gmail.com: Move to new HardwareInfo] Signed-off-by: Jason Edson <jaysonedson@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
neobuddy89: Updated for A16 QPR1
Squashed:
From: Pranav Vashi <neobuddy89@gmail.com>
Date: Fri, 17 Dec 2021 02:51:46 +0530
Subject: Settings: Set device name from marketname if available
From: Hikari-no-Tenshi <kyryljan.serhij@gmail.com>
Date: Mon, 27 Dec 2021 14:09:31 +0200
Subject: Fix device name change
Change-Id: If974ac38638fca9b100008d1b5404d876faf42e2
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I61fd4d77375df019da94ed7fca71da157dd0f415
Co-authored-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: Id4ac89dba079ab46dcb7d97cca7b2c4c8f9fb612 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* Setting up a new SD card is currently using light theme, no matter the system setting * Convert to DayNight to have it follow system theme Change-Id: Iaf41c95a03859f40f9895b713c26ee76ff01fed6 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I2c93301a7a9aa640278c62912ee6a54dbe29589c Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: jhonboy121 <alfredmathew05@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: If270186b7788d95bfb4f555c0bc6f7eb3367e95f Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I3716ff409ba3fb830abaa906a55bb49daed47451 Signed-off-by: Alvin Francis <nivlafx@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I91e75eab0b6d9ffc608af1f5977ddd79350b22fc Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
- so that it expands and shows full kernel version Change-Id: Ic08ec7a1db62a521e434cac5188aad2d35a4825d Signed-off-by: SagarMakhar <sagarmakhar@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
idoybh edits: Move to about phone in settings Signed-off-by: Omkar Chandorkar <gotenksIN@aosip.dev> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I481485b2563fdb27b35b31fa95795db94a863f2f Signed-off-by: LynnrinChan <lynnrin@lynnrin.moe> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Fixes: crdroidandroid/issue_tracker#891 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
For the DNS tile long press intent in base Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Read the default value from settingsprovider resources, which may be customized via overlay. Change-Id: If5a02e6c45fe195b4f69ff9ede4fdb20dcb3d925 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
For some reason, google has made this line empty. crdroidandroid@493f7ac
This reverts commit e01a642.
Change-Id: If9f0c1000ff4e7dd0b602a61299f1eb2c7608ac5 Signed-off-by: cjybyjk <cjybyjk@zjnu.edu.cn> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I80aebe3ca8e13e3dc5c503d5a8527282e96e486a Co-authored-by: Pranav Vashi <neobuddy89@gmail.com> Co-authored-by: jhonboy121 <alfredmathew05@gmail.com> Signed-off-by: cjybyjk <cjybyjk@zjnu.edu.cn> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: cjybyjk <cjybyjk@zjnu.edu.cn> Change-Id: I8a222a9a9ae8f005953b738368168d551a502491 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Using a fixed layout size meant that the view was becoming scrollable in landscape mode. Instead use the parent size with a max height and width. Center the layout and cleanup unused elements while at it. Change-Id: If39d67d679a3e77bc9210e98885b4addfd1660d7 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Make sure these buttons match the rest of the UI. See buttons in storage, text to speech, batter saver, etc. Now they match :-) Change-Id: I7c478b8d44924e3598bbb322650ad6c355b5792d Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Avoid scrolling by making the illustration fit available space. Change-Id: I5300875b7790ee3664eff22d3517289ed04ef696 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* rather than going to apps one by one, this preference allows users to open the page where it'll list all apps with filters and stuff. Signed-off-by: jhonboy121 <alfredmathew05@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: If51d68b298a0b4315e0c3b8c1fa8290d37116292 Signed-off-by: kleidione <kleidione@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I35525437a6627b97e847419ad9413a78eae353e5 Signed-off-by: inferno0230 <mail@inferno0230.in> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I87288e90f7bd0646e42b4c56ea56dd53a9bf0601 Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
if a device doesn't support tap or lift to wake, you could still search for "show ambient" and get into the pages anyway. this makes search actually check if the feature exists first before showing it. Signed-off-by: Dmitrii <bankersenator@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Reachability check didn't consider WPA3 or OWE only configuration. Now, it's checked them properly. To do so, isSecurityTypeEnabled(int) in WifiConfiguration by Ibfa6558b223d2b424b3ca60cbc9c7a0941e83aba in Wifi module is expected to be available to use. Test cases are also expected to the new Wifi module. TEST: atest com.android.settings.wifi.dpp.WifiDppQrCodeScannerFragmentTest Change-Id: I3ecaa0ba1647a962a04efe1eb540bcc0368f6edd
Despite the name getTabId, onCreateView treats this tabId as a starting tab index, i.e. the tab that will be selected on first state. However, it's possible to have tabId != tabIndex in certain cases like launching android.settings.CREDENTIAL_PROVIDER in an app from a private profile. PRIVATE_TAB is 2, but if there was no work profile, then there would only be Personal (index 0) and Private (index 1) tabs. Using PRIVATE_TAB (2) as the index results in an NPE in onCreateView. If there was a work profile, then there would be Personal, Private, and Work tabs. The intent android.settings.CREDENTIAL_PROVIDER from private profile will actually select the Work tab, because the index PRIVATE_TAB (2) is used with Work tab in that index. Fix this by making it very clear that this is a function used to get starting tab index, and then stop assuming the positions. This never crashed when opening Settings app from the full user, because starting tab of Personal is always correct for that case. The tests have also been updated to reflect the case of launching from a private profile. The test ViewPager is now required for all tests; this reflects the actual usage in the code anyway. Bug: 499908921 Test: manual, atest SettingsRoboTests:com.android.settings.dashboard.profileselector.ProfileSelectFragmentTest Change-Id: I8a7f9b595d053d9f6fdb94e241c3c9c2c8e2062a
…type is not LTE & above Signed-off-by: Arindam Bhattacharjee <abhattacharjee717@gmail.com>
…te 2G toggle Signed-off-by: Arindam Bhattacharjee <abhattacharjee717@gmail.com>
…eboot Signed-off-by: Arindam Bhattacharjee <abhattacharjee717@gmail.com>
If Dolby preference exist inside the Sound & Vibration option, then set the preference in Audio section Signed-off-by: Arindam Bhattacharjee <abhattacharjee717@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d97f3d281e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+131
to
+133
| subscriptionManager.setDefaultDataSubId(restoredSubId); | ||
| rememberSelection(context, subscriptionManager, restoredSubId); | ||
| return true; |
There was a problem hiding this comment.
This auto-restore path sets DDS and immediately returns success, which suppresses the user dialog, but it never enables DATA_ENABLED_REASON_USER on the restored subscription. On devices where that user-data bit is not carried over to the new subId (a common reason the data-pick dialog appears), users can end up with a restored default data SIM but no cellular data and no prompt to fix it.
Useful? React with 👍 / 👎.
neobuddy89
force-pushed
the
16.0
branch
2 times, most recently
from
a1ea493 to
6921ca6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.