Skip to content

Use native Request objects in signing examples - #787

Open
timkelty wants to merge 1 commit into
mainfrom
timkelty/use-native-request-signing
Open

timkelty wants to merge 1 commit into
mainfrom
timkelty/use-native-request-signing

Conversation

@timkelty

Copy link
Copy Markdown
Contributor

Summary

  • construct native Request objects before generating signature headers
  • send the same signed request object so @target-uri matches the normalized URL
  • clone requests in the native retry helper so POST bodies can be retried
  • recommend URL.searchParams for encoding query parameters

Testing

  • git diff --check
  • verified native Request URL normalization matches the sent URL
  • verified cloned POST requests preserve their body across a retry

@timkelty
timkelty requested a review from a team as a code owner September 16, 2026 01:45
@netlify

netlify Bot commented Sep 16, 2026

Copy link
Copy Markdown

Deploy Preview for craft-docs ready!

Name Link
🔨 Latest commit 9df7574
🔍 Latest deploy log https://app.netlify.com/projects/craft-docs/deploys/6aa9f4ba480b980008d5b5bb
😎 Deploy Preview https://deploy-preview-787--craft-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-16T01:48:01.939954Z 9df7574 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant