Don’t log warnings in SSO user attribute mapping for native user properties#19294
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces log noise during SSO logins by avoiding warning logs when an attribute mapping targets native User properties (e.g. email, firstName, lastName) rather than missing custom fields.
Changes:
- Updated SSO user attribute mapping field-resolution logic to only warn when a mapped custom field can’t be found.
- Added a release note describing the reduced warning logging for native user properties.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/auth/sso/mapper/SetUserValueTrait.php |
Adjusts when “field not found” warnings are emitted during SSO user attribute mapping. |
CHANGELOG.md |
Notes the logging behavior change under an Unreleased section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, every time an SSO user logs in, the logs fill up with warnings for common mappings like
email,firstName, andlastName.This PR changes it so it logs only warnings for missing custom fields that are being mapped but don’t exist in Craft.