bring back missing toast notifications on element(s) delete#19028
Open
i-just wants to merge 1 commit into
Open
bring back missing toast notifications on element(s) delete#19028i-just wants to merge 1 commit into
i-just wants to merge 1 commit into
Conversation
i-just
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
v5.10.0 introduced the deletion blockers, but it looks like the toast notifications are missing from that new flow.
While those might not be as crucial when the deletion blockers modal kicks in, they’re also missing from flows that don’t trigger the blockers. This PR brings them back (regardless of whether the user saw the deletion blockers modal or not).
Related issues
#19017