Improve static cache purge diagnostics#194
Conversation
There was a problem hiding this comment.
Pull request overview
Improves static cache purge diagnostics by enriching Cloud module log contexts with request metadata and by making cache tags serialize both their normalized and original values for clearer troubleshooting.
Changes:
- Add request context (
requestedRoute,requestedParams,url) automatically toModule::log()messages. - Include collected purge inputs (
tags,fetchUrls) in the “Failed to purge tags after request” error log. - Update
StaticCacheTagJSON serialization to return structured data (value,originalValue) and add unit tests covering the new behaviors.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/StaticCacheTagTest.php | Adds coverage for StaticCacheTag’s structured JSON serialization. |
| tests/unit/ModuleTest.php | Adds coverage for Module::log() request-context enrichment. |
| src/StaticCacheTag.php | Changes jsonSerialize() to return an array including normalized and original values. |
| src/StaticCache.php | Adds purge failure log context for tags and fetch URLs. |
| src/Module.php | Enriches log context with request route/params and absolute URL (web-only). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 597a134f85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adds request context and the collected tags/fetch URLs to purge failure logs, while serializing cache tags with both normalized and original values. This should make customer-specific rate-limit failures traceable to the request and purge inputs.