CQL Long by cmoesel · Pull Request #363 · cqframework/cql-execution

cmoesel · 2026-05-11T12:47:06Z

This PR introduces support for CQL Long, represented using BigInt in JavaScript. Since Integer and Decimal are represented using Number, we can easily distinguish CQL Longs from Integers and Decimals by their type (typeof var === 'bigint'). This actually made implementation easier (and more correct) compared to my initial implementation using Number (which I thought would be easier since it was more of an incremental change, but maybe not).

You can test this by building and running a CQL library that uses Long types -- or you can just review the unit tests and trust that they are properly exercising the capability.

Submitter:

This pull request describes why these changes were made
Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
Tests are included and test edge cases
Tests have been run locally and pass
Code coverage has not gone down and all code touched or added is covered.
Code passes lint and prettier (hint: use npm run test:plus to run tests, lint, and prettier)
All dependent libraries are appropriately updated or have a corresponding PR related to this change (N/A)
cql4browsers.js built with npm run build:browserify if source changed.

Reviewer:

Name:

Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
The tests appropriately test the new code, including edge cases
You have tried to break the code

codecov-commenter · 2026-05-11T12:48:48Z

Codecov Report

❌ Patch coverage is 84.85915% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.30%. Comparing base (73bf45e) to head (c181ffa).

Files with missing lines	Patch %	Lines
src/elm/type.ts	70.17%	14 Missing and 3 partials ⚠️
src/elm/interval.ts	79.48%	4 Missing and 4 partials ⚠️
src/util/math.ts	89.47%	6 Missing ⚠️
src/elm/arithmetic.ts	88.37%	4 Missing and 1 partial ⚠️
src/datatypes/interval.ts	90.62%	2 Missing and 1 partial ⚠️
src/runtime/context.ts	25.00%	2 Missing and 1 partial ⚠️
src/elm/literal.ts	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   87.69%   88.30%   +0.60%     
==========================================
  Files          52       54       +2     
  Lines        4624     4804     +180     
  Branches     1307     1350      +43     
==========================================
+ Hits         4055     4242     +187     
- Misses        354      369      +15     
+ Partials      215      193      -22

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lmd59

Looking good! The tests are very thorough and helpful for confirming successful implementation. I left a couple of small comments on tests. Most are just nitpick/optional, but I think a couple more aggregate tests wouldn't hurt.

I also wanted to ask about support for Long in the interval datatype
https://cql.hl7.org/04-logicalspecification.html#interval states that "An interval must be defined using a point type that supports comparison, as well as Successor and Predecessor operations, and Minimum and Maximum Value operations." Long seems like it would fit in this category. Is there any reason not to support Long as part of an interval?

cmoesel · 2026-05-19T17:05:18Z

Thanks for the excellent review! You uncovered some gaps in my implementation and also helped me to find more gaps on my own. But I will also note: be careful what you wish for! I just added a lot more changes and tests.

I added support for Interval<Long> in 79c0fb8, including support for multiple operations that work on intervals.
I added tests for sum and product overflow/underflow and in the process discovered we weren't checking for overflow/underflow at all, so I also fixed the implementation. See: 6eaf011.
This led me to realize that we could improve our type handling in general by using ELM result types when they are available, so I did that and fixed a bunch of related stuff in 4b5e62d. That one's kind of big.
And finally, I found a couple more spots where we weren't explicitly accounting for long/bigint, so I fixed those in 9620bb8.

Thanks again for the great review. Sorry for adding a bunch more work for your review!

cmoesel · 2026-05-27T13:12:21Z

FYI: I rebased this branch on master to take in the latest test-server changes. There was minimal impact to the changes in this branch (just some small changes in tsconfig.json).

lmd59

Excellent updates, and addressing a lot of new Long functionality and improved type handling!
I added some comments, but most of them are small!

cmoesel · 2026-06-01T16:31:39Z

Fantastic feedback again, @lmd59. You're making me feel like I'm getting sloppy. Thanks for the thorough review and great finds. I'll fix these soon (but probably not today).

- Add support for Long literal, ToLong conversion, min/max long values - Use JavaScript Number to represent Long (NOTE: this means that values are imprecise outside of the safe integer range in JS) - Add tests for literals, conversion, and other operations that accept Long arguments - Improve underflow/overflow tests to test boundaries more carefully - Added .skip to tests that fail due to Number imprecision for high values - Unskipped Long tests in the spec tests that now pass

Update support for Long to use BigInt so we can distinguish between decimal/integer (JS Number) and long (JS BigInt).

- support for <, <=, >=, > for long/bigint types - support for ConvertsToLong and Convert operator with Long

Co-authored-by: lmd59 <lmd59@cornell.edu>

- Add optional resultTypeName property to base Expression class - Use resultTypeName when possible to distinguish between decimal and integer - Use constants for ELM type strings (e.g., {urn:hl7-org:elm-types:r1}Decimal) - Update spec-test-data generator CQL-to-ELM to produce resultTypes - Unskip tests that are now passing - Fix tests that were unintentionally incorrect based on previous incomplete type support

…ifier

Co-authored-by: lmd59 <lmd59@cornell.edu>

- Remove unnecessary abs and ternaries in Interval.width() and Interval.size() - Fix possible overflows in Interval.getPointSize() - Refactor Interval.getPointSize() to return Quantity | Number | BigInt - Update Product CQL tests to pass a second argument - Remove redundant interval tests and clarify test names where appropriate

Rebase mistakenly duplicated types in compilerOptions.

- Modulo divide by zero should return null - Abs and Negate can overthrow when minimum integer or long are passed in - ToInteger and ToLong should return null for empty and invalid strings - Account for incorrect resultTypeName (from translator) in overflowsOrUnderflows

cmoesel · 2026-06-23T16:46:40Z

@lmd59 - I have addressed all of your comments (I think) plus a few more things that I discovered along the way. This is ready for re-review.

@dehall - I welcome your review as well.

lmd59

Just one tiny question - looking great to me! Excited that this will be supported soon!

Co-authored-by: lmd59 <lmd59@cornell.edu>

dehall

This looks good. I came at this primarily from the perspective of how one might build off this for a future "BigDecimal"-based type and I feel like this is a good model to follow. One or maybe two spots I might have refactored some duplicate logic into a helper function but mixing JS primitives with classes means that's not really possible very often.

In the interest of understanding what our modern AI tools are capable of I did ask Codex to see what it thought, and it highlighted a few items which I confirmed. I think the 2 Uncertainty code suggestions I made are necessary but I defer to you on what you want to do for everything else

cmoesel · 2026-06-30T19:06:10Z

Thanks for the review @dehall. I've addressed your comments.

I was tempted to add a whole new suite of decimal tests in the interval tests (like the IntegerInterval and LongInterval suites), but I decided against it since it is slightly outside the scope of this PR and since we'll probably be updating Decimal support soon anyway.

cmoesel mentioned this pull request May 11, 2026

Implement CQL Long #361

Closed

11 tasks

cmoesel marked this pull request as draft May 11, 2026 13:53

cmoesel marked this pull request as ready for review May 11, 2026 15:26

cmoesel force-pushed the cql-long branch from 8ecd7b5 to 9bbb25d Compare May 11, 2026 18:39

elsaperelli requested a review from lmd59 May 12, 2026 14:20

elsaperelli assigned lmd59 May 12, 2026

lmd59 reviewed May 14, 2026

View reviewed changes

Comment thread test/elm/literal/literal-test.ts Outdated

Comment thread test/elm/literal/literal-test.ts Outdated

Comment thread test/elm/arithmetic/data.cql

Comment thread test/elm/aggregate/data.cql

Comment thread test/elm/aggregate/data.cql

cmoesel force-pushed the cql-long branch from 9620bb8 to 5e4472f Compare May 27, 2026 13:09

This was referenced May 29, 2026

Improve handling of boundless and unknown intervals #365

Draft

Fix overlaps for boundless and unknown intervals #366

Merged

lmd59 reviewed May 31, 2026

View reviewed changes

cmoesel and others added 11 commits June 22, 2026 17:35

Support for Long as JS BigInt

a79fbe2

Update support for Long to use BigInt so we can distinguish between decimal/integer (JS Number) and long (JS BigInt).

Long: comparison and conversion

9d522db

- support for <, <=, >=, > for long/bigint types - support for ConvertsToLong and Convert operator with Long

Remove commented out skipped long tests

d7f6c68

Update test case descriptions to be more clear

b40962e

Co-authored-by: lmd59 <lmd59@cornell.edu>

Support for Interval<Long> and related operations

5033228

Handle overflow/underflow for Sum and Product

f4b1869

Improve long/bigint support in ToQuantity and when guessing type spec…

922bade

…ifier

Minor typos from code review

69a6b6e

Co-authored-by: lmd59 <lmd59@cornell.edu>

cmoesel force-pushed the cql-long branch from bb6e72c to b36e5ff Compare June 22, 2026 21:39

cmoesel added 3 commits June 22, 2026 21:29

Handle long separately in intervalListType to avoid confusion

a0590e9

Remove redundant types from test/tsconfig.json

e15a0ae

Rebase mistakenly duplicated types in compilerOptions.

Fix power for negative exponents with Long type

19caa45

lmd59 reviewed Jun 25, 2026

View reviewed changes

Comment thread test/elm/arithmetic/data.cql

Add skipped test for 2L ^ minimum Long

1f0cb98

lmd59 reviewed Jun 26, 2026

View reviewed changes

Comment thread test/elm/arithmetic/arithmetic-test.ts Outdated

lmd59 approved these changes Jun 26, 2026

View reviewed changes

Fix typo: TOODO --> TODO

82af47e

Co-authored-by: lmd59 <lmd59@cornell.edu>

dehall requested changes Jun 26, 2026

View reviewed changes

Comment thread src/util/math.ts Outdated

Comment thread src/util/math.ts Outdated

Comment thread src/elm/interval.ts

Comment thread src/elm/type.ts

cmoesel added 3 commits June 30, 2026 14:24

Pass in type to successor/predecessor where feasible

ede09db

Expand per 0 should return null

5942e0b

Add comment about converting bigint to number for Quantities

c181ffa

cmoesel requested a review from dehall June 30, 2026 19:04

dehall approved these changes Jun 30, 2026

View reviewed changes

Uh oh!

Conversation

cmoesel commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lmd59 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmoesel commented May 19, 2026

Uh oh!

cmoesel commented May 27, 2026

Uh oh!

lmd59 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmoesel commented Jun 1, 2026

Uh oh!

cmoesel commented Jun 23, 2026

Uh oh!

lmd59 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dehall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmoesel commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmoesel commented May 11, 2026 •

edited

Loading

codecov-commenter commented May 11, 2026 •

edited

Loading