Fix #14604 & #10343: Implicit return type in typedefs#8457
Open
ludviggunne wants to merge 3 commits intocppcheck-opensource:mainfrom
Open
Fix #14604 & #10343: Implicit return type in typedefs#8457ludviggunne wants to merge 3 commits intocppcheck-opensource:mainfrom
ludviggunne wants to merge 3 commits intocppcheck-opensource:mainfrom
Conversation
ludviggunne
force-pushed
the
14604-10343
branch
from
ab6c652 to
44c05b1
Compare
ludviggunne
force-pushed
the
14604-10343
branch
from
44c05b1 to
549935e
Compare
|
danmar
reviewed
Apr 25, 2026
| if (tok->str() == "typedef") { | ||
| if (Token::simpleMatch(tok, "typedef ( *") && Token::simpleMatch(tok->linkAt(1), ") (")) | ||
| // Implicit return type | ||
| tok->insertToken("int"); |
Collaborator
There was a problem hiding this comment.
ensure that Token::isImplicitInt will be true
| ASSERT_EQUALS(" <typedef-info>\n" | ||
| " <info name=\"pfi\" file=\"file.c\" line=\"1\" column=\"1\" used=\"0\" isFunctionPointer=\"1\">\n" | ||
| " <token line=\"1\" column=\"1\" str=\"typedef\"/>\n" | ||
| " <token line=\"1\" column=\"0\" str=\"int\"/>\n" |
Collaborator
There was a problem hiding this comment.
we need to say that this int is implicit somehow. I suggest adding an isImplicitInt attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.