feat: Switch clang tools from static binaries to wheels#368
feat: Switch clang tools from static binaries to wheels#368shenxianpeng merged 15 commits intomainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughREADME install instructions now prefer wheels with OS-specific fallback order and updated links/licensing. action.yml adds version validation/normalization, switches Windows detection to Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Cpp-Linter Report
|
|
I think there's a bug in clang-tools-pip. It does not seem to match v9.0.0. Probably a logical error ( |
This comment was marked as resolved.
This comment was marked as resolved.
29a60ef to
d3e381b
Compare
2bndy5
left a comment
There was a problem hiding this comment.
I have pushed any changes that I requested.
This is now the least breaking implementation that I can muster.
Also, the README now states the origin of clang tools in order of install attempts.
Caution
This should be tested in test repo before merging.
We have made some significant changes to how version input is used before it is passed to cpp-linter.
|
Seems to work as expected when
|
|
ok, so the nushell script handles a path as the version input:
This works if the path points to a folder where clang-tidy and/or clang-format binaries exist.
This is because cpp-linter-hooks installs a version of clang tools as dependencies: @shenxianpeng Can we remove the unnecessary dependencies in cpp-linter-hooks? This isn't a deal breaker. It just causes confusion when the given path is wrong. |
Co-authored-by: Brendan <2bndy5@gmail.com>
Co-authored-by: Brendan <2bndy5@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 74d1224.
|
Let's merge this PR and publish a minor release. |
closes #364
Summary by CodeRabbit
Documentation
Chores