Skip to content

ci(workflows): pin pnpm version via packageManager field#12

Merged
myasnikovdaniil merged 1 commit into
mainfrom
ci/bump-pnpm-11
May 18, 2026
Merged

ci(workflows): pin pnpm version via packageManager field#12
myasnikovdaniil merged 1 commit into
mainfrom
ci/bump-pnpm-11

Conversation

@myasnikovdaniil
Copy link
Copy Markdown
Contributor

@myasnikovdaniil myasnikovdaniil commented May 18, 2026

What

Add "packageManager": "pnpm@11.1.2" to the root package.json.

Why

The test workflow added in #5 has been failing on every run with
No pnpm version is specifiedpnpm/action-setup@v4 requires either
a version: input on the action or a packageManager field in
package.json. The latter is the preferred declaration because it
also pins the version for local developers, not just CI.

Pin to pnpm 11 (current latest, stable on Node 20+) so contributors
land on a still-supported line. Lockfile format (lockfileVersion: 9.0)
is unchanged between pnpm 10 and 11, so no lockfile churn is required.

Alternative to #7, which proposes pinning to pnpm@10.26.0.

Verification

  • pnpm install --frozen-lockfile — clean, no lockfile diff
  • pnpm typecheck — all 4 workspaces pass
  • pnpm test — 29/29 passing

Once merged, the test check should go green on main and on
subsequent PRs.

Summary by CodeRabbit

  • Chores
    • Pinned package manager version to ensure consistent development environment across the project.

Review Change Stack

Add `"packageManager": "pnpm@11.1.2"` to the root `package.json`.

The `test` workflow added in #5 has been failing on every run with
`No pnpm version is specified` — `pnpm/action-setup@v4` requires either
a `version:` input on the action or a `packageManager` field in
`package.json`. The latter is the preferred declaration because it
also pins the version for local developers, not just CI.

Pin to pnpm 11 (current latest, stable on Node 20+) rather than 10.x
so contributors picking up the project land on a still-supported line.
Lockfile format (`lockfileVersion: 9.0`) is unchanged between pnpm 10
and 11, so no lockfile churn is required.

Verified locally on pnpm 11.1.2:
- `pnpm install --frozen-lockfile` — clean, no lockfile diff
- `pnpm typecheck` — all 4 workspaces pass
- `pnpm test` — 29/29 passing

Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d56c10c8-816b-4d99-92fc-ef85d9a7bfb2

📥 Commits

Reviewing files that changed from the base of the PR and between fa41573 and 9fae52f.

📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

The root package.json now includes a packageManager field that pins the project to pnpm@11.1.2. This standardizes the package manager version across all developers and CI environments using this configuration field.

Changes

Package Manager Pinning

Layer / File(s) Summary
Package manager version pinning
package.json
The packageManager field is added to enforce pnpm@11.1.2 as the required package manager for the project.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single line, so neat and small,
Pnpm eleven, pinned for all!
Version locked, the config's blessed,
One tiny change to pass the test. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a packageManager field to pin pnpm version in package.json for CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/bump-pnpm-11

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates package.json to pin the package manager to pnpm@11.1.2. The reviewer recommends also adding an engines field to specify the required Node.js version, ensuring better environment compatibility.

Comment thread package.json
@myasnikovdaniil myasnikovdaniil merged commit 4de877e into main May 18, 2026
3 checks passed
@myasnikovdaniil myasnikovdaniil deleted the ci/bump-pnpm-11 branch May 18, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants