ci(workflows): pin pnpm version via packageManager field#12
Conversation
Add `"packageManager": "pnpm@11.1.2"` to the root `package.json`. The `test` workflow added in #5 has been failing on every run with `No pnpm version is specified` — `pnpm/action-setup@v4` requires either a `version:` input on the action or a `packageManager` field in `package.json`. The latter is the preferred declaration because it also pins the version for local developers, not just CI. Pin to pnpm 11 (current latest, stable on Node 20+) rather than 10.x so contributors picking up the project land on a still-supported line. Lockfile format (`lockfileVersion: 9.0`) is unchanged between pnpm 10 and 11, so no lockfile churn is required. Verified locally on pnpm 11.1.2: - `pnpm install --frozen-lockfile` — clean, no lockfile diff - `pnpm typecheck` — all 4 workspaces pass - `pnpm test` — 29/29 passing Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe root ChangesPackage Manager Pinning
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Add
"packageManager": "pnpm@11.1.2"to the rootpackage.json.Why
The
testworkflow added in #5 has been failing on every run withNo pnpm version is specified—pnpm/action-setup@v4requires eithera
version:input on the action or apackageManagerfield inpackage.json. The latter is the preferred declaration because italso pins the version for local developers, not just CI.
Pin to pnpm 11 (current latest, stable on Node 20+) so contributors
land on a still-supported line. Lockfile format (
lockfileVersion: 9.0)is unchanged between pnpm 10 and 11, so no lockfile churn is required.
Alternative to #7, which proposes pinning to
pnpm@10.26.0.Verification
pnpm install --frozen-lockfile— clean, no lockfile diffpnpm typecheck— all 4 workspaces passpnpm test— 29/29 passingOnce merged, the
testcheck should go green onmainand onsubsequent PRs.
Summary by CodeRabbit