Rename SelfOrder to SettlementOwnedOrder - #162
Merged
Merged
Conversation
kaze-cow
reviewed
Sep 22, 2026
kaze-cow
left a comment
kaze-cow
left a comment
Contributor
There was a problem hiding this comment.
name change is fine, I wont block it. but you could consider a synonym for "Self" such as CreateEndogonousOrder or CreateDomesticOrder
"Sweep" sounds like its kind of changing the meaning fundamentally, though its not wrong to our expected purpose.
anxolin
approved these changes
Sep 22, 2026
anxolin
left a comment
anxolin
left a comment
Contributor
There was a problem hiding this comment.
Personally I din't mind sweep, and I can't pronounce "Endogonous". I would leave it as it is if we can't finds sth simple that fits
Contributor
|
what about |
fedgiac
force-pushed
the
federico/sc-421-rename-selforder
branch
from
September 28, 2026 11:26
ba6e005 to
c57e733
Compare
fedgiac
changed the title
kaze-cow
approved these changes
Sep 28, 2026
fedgiac
force-pushed
the
federico/sc-421-rename-selforder
branch
from
September 28, 2026 11:31
c57e733 to
cf08312
Compare
kaze-cow
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was pointed out that
Selforder sounds too similar toSellorder and can be confusing.This PR just renames self orders to sweep orders.
The name was discussed in a few places, including this PR, and we settled on it in a call.
How to test
CI, check there are no differences.