Skip to content

Fix flaky TestGetRules: stop scheduled evaluations from racing pre-evaluation state assertions #7857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix flaky TestGetRules: stop scheduled evaluations from racing pre-evaluation state assertions #7857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed2d28
Initial plan
Copilot Sep 21, 2026
bc50fdf
Fix flaky TestGetRules by preventing scheduled rule evaluation
Copilot Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pkg/ruler/ruler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,10 +917,10 @@ func TestGetRules(t *testing.T) {
"user3": 0,
},
},
"No Sharding with Alert state filter for inactive alerts": {
"No Sharding with Alert state filter for unknown alerts": {
sharding: false,
rulesRequest: RulesRequest{
State: unknownStateFilter, // Prometheus v2.x uses "unknown" for unevaluated alerts
State: unknownStateFilter, // Prometheus uses the "unknown" state for alerting rules that have not been evaluated yet.
MaxRuleGroups: -1,
},
rulerStateMap: rulerStateMapAllActive,
Expand Down Expand Up @@ -1363,7 +1363,13 @@ func TestGetRules(t *testing.T) {
cfg.Ring.InstanceZone = tc.rulerAZMap[id]
}

r, _ := buildRuler(t, cfg, nil, store, rulerAddrMap)
// Use a no-op GroupEvalIterationFunc to keep rules in their pre-evaluation state ("unknown"
// alert state and "unknown" health). The scheduled evaluation of a group can otherwise fire
// within the test window (the first evaluation is slotted at a hash-based offset within the
// group interval) and move rules out of the state asserted by the state/health filter cases.
noopEvalIterationFunc := func(ctx context.Context, g *promRules.Group, evalTimestamp time.Time) {}

r, _ := buildRulerWithIterFunc(t, cfg, nil, store, rulerAddrMap, noopEvalIterationFunc)
r.limits = &ruleLimits{tenantShard: tc.shuffleShardSize}
rulerAddrMap[id] = r
if r.ring != nil {
Expand Down