feat(parquetconverter): Add max-num-columns config for automatic parquet sharding#7624
Open
yeya24 wants to merge 1 commit into
Open
feat(parquetconverter): Add max-num-columns config for automatic parquet sharding#7624yeya24 wants to merge 1 commit into
yeya24 wants to merge 1 commit into
Conversation
dosubot
Bot
added
dependencies
yeya24
force-pushed
the
feat/parquet-max-columns
branch
from
33fcd02 to
bc753c2
Compare
…uet sharding Bump parquet-common to include PR #131 which adds automatic parquet file sharding based on a configurable column limit. The parquet-go library has a hard limit of 32767 columns; this feature allows users to set a lower limit and automatically shard into multiple files when the number of unique label names would exceed it. Changes: - Bump parquet-common to 5f32460b5373 (merged column sharding PR) - Add -parquet-converter.max-num-columns flag (default 0 = library default) - Add MaxNumColumns to Config struct and wire into convert options - Add TestConvertWithMaxNumColumns integration test - Update v1-guarantees.md with experimental feature entry - Regenerate docs and JSON schema Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
feat/parquet-max-columns
branch
from
bc753c2 to
bf79b91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Bumps parquet-common to include PR #131 which adds automatic parquet file sharding based on a configurable column limit.
The parquet-go library has a hard limit of 32767 columns per file. When a TSDB block has more unique label names than this limit, conversion would fail. This feature allows users to set a lower limit via
-parquet-converter.max-num-columnsand automatically shard into multiple parquet files when the number of unique label names would exceed it.Changes
-parquet-converter.max-num-columnsflag (default 0 = library default of 32767)MaxNumColumnsto Config struct and wire into convert optionsTestConvertWithMaxNumColumnsintegration testHow to test
The new test
TestConvertWithMaxNumColumnsverifies:WithMaxNumColumns(20): produces multiple shards when 50 unique label names existWithMaxNumColumns(10000): produces a single shard (no sharding needed)go test ./pkg/parquetconverter/... -run TestConvertWithMaxNumColumns -v