Fix compactor to handle not-found error in Attributes when updating block index#7454
Merged
friedrichg merged 3 commits intocortexproject:masterfrom Apr 30, 2026
Merged
Fix compactor to handle not-found error in Attributes when updating block index#7454friedrichg merged 3 commits intocortexproject:masterfrom
friedrichg merged 3 commits intocortexproject:masterfrom
Conversation
index. Handle not-found and access-denied errors from `Attributes()` in bucket index updater, preventing a stale cached `Get()` from causing the entire cleanup cycle to fail when `meta.json` has been deleted from object storage. - Return ErrBlockMetaNotFound if meta.json attributes are missing - Extend MockBucketFailure to support AttributesFailures for testing - Add test to verify updater skips blocks with missing meta attributes Fixes cortexproject#7453 Signed-off-by: alex.berger <alex-berger@gmx.ch>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
friedrichg
reviewed
Apr 28, 2026
SungJin1212
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Handle not-found and access-denied errors from
Attributes()in bucket index updater, preventing a stale cachedGet()from causing the entire cleanup cycle to fail whenmeta.jsonhas been deleted from object storage.Which issue(s) this PR fixes:
Fixes #7453
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags