docs(change): propose CR-132 triagecore CLI architecture accounting - #166
Open
coreytshaffer wants to merge 2 commits into
Open
docs(change): propose CR-132 triagecore CLI architecture accounting#166coreytshaffer wants to merge 2 commits into
coreytshaffer wants to merge 2 commits into
Conversation
Proposal-only. Records that current_system_architecture.md claims repository-level current architecture but its verified-source set and integration table omit the packaged triagecore CLI surface entirely, hiding a working supervisor-review subsystem and a currently non-operational Worker Council path (UI requests repo_mapper/ code_repair/validator; WorkerRegistry exposes only context_planner/ test_stubber/review_worker/implementer). Grants no implementation, design, or merge authority, and deliberately excludes the runtime role-mapping defect from this documentation-accounting scope. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
✅ Deploy Preview for poetic-quokka-0fd859 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…dence labels Corrective proposal-only commit, per bounded corrective authority from PR head ce13627. Three substantive fixes: - Add a read-only census of all top-level triagecore commands (desk, audit, codex-task, antigravity-task, init-agents, install-desktop, push-task, benchmark, benchmark-report, propose-lessons, review-lesson, import-learning-seeds, record-supervisor-review, import-supervisor-usage, scan-supervisor-usage, run-pipeline, stability-pass, stats, lab). Supervisor review and Worker Council are the two motivating findings, not an exhaustive account of the binary; the eventual documentation scope now requires grouping the full command set rather than stopping at those two rows. - Replace the single "lookup always misses" Worker Council mechanism with the two mechanisms orchestration.py actually has: a registry lookup miss for non-chunked inputs, versus zero work orders ever queued (lookup never reached) for chunked inputs, since the chunked branch only recognizes context_planner/implementer role names. - Relabel tests/test_ui_smoke.py and tests/test_orchestration.py accurately: neither reproduces the GUI's mismatched repo_mapper/code_repair/validator dispatch, so the defect is code-path evidence, not a regression-test result. Also rephrases the namespace-census note so the 6f5970d architecture-mapping commit is cited as prior comparable work, not as plain-numeric-lineage precedent (it was never a CR). No runtime, test, schema, CLI, worker-registry, orchestration, UI, or skill-file change. No edit to current_system_architecture.md. Two-lane separation and all prior exclusions preserved. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/architecture/current_system_architecture.mdclaims repository-level current architecture but its verified-source list and integration table omit the packagedtriagecoreCLI surface (triage_core/cli.py) entirely, even thoughpyproject.tomlpackages it as a second console script alongsidetc.triagecoreis a large surface — a read-only census found 19 top-level commands (desk,audit,codex-task,antigravity-task,init-agents,install-desktop,push-task,benchmark,benchmark-report,propose-lessons,review-lesson,import-learning-seeds,record-supervisor-review,import-supervisor-usage,scan-supervisor-usage,run-pipeline,stability-pass,stats,labwithreport/export/trainsubcommands). Supervisor review and the TriageDesk "Worker Council" path are the two motivating findings that surfaced the gap, not an exhaustive description of the binary — the eventual documentation scope must account for the full command surface, not stop at those two rows.record-supervisor-review/scan-supervisor-usage/import-supervisor-usage) is real, working, tested, and already documented operationally (docs/verification_guide.md§6,docs/evidence_schema.md) — just missing from the architecture map.WorkerRegistryexact-key lookup miss for non-chunked inputs (UI requestsrepo_mapper/code_repair/validator; registry only exposescontext_planner/test_stubber/review_worker/implementer), versus zero work orders ever being queued at all for chunked inputs (the chunking branch only recognizescontext_planner/implementerrole names, so the registry lookup is never reached). Both are established by direct code-path reading, not by an existing regression test —tests/test_orchestration.pyandtests/test_ui_smoke.pydo not reproduce either failure mode.Test plan
CR-132non-colliding) still holds at review time.🤖 Generated with Claude Code