chore: allow unused async trait handlers - #111
Open
lucarlig wants to merge 3 commits into
Open
Conversation
Signed-off-by: lucarlig <luca.carlig@ibm.com>
lucarlig
marked this pull request as ready for review
August 21, 2026 16:47
This reverts commit 5f5f497. Signed-off-by: lucarlig <luca.carlig@ibm.com>
Signed-off-by: lucarlig <luca.carlig@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippy::unused_async_trait_implat workspace scopeThis is the one-line bottom PR beneath #107 and #109.
Why this lint is allowed
Clippy's
unused_async_trait_impldocumentation explains that the lint flagsasynctrait-method implementations with no.await. It was added in Rust 1.98 as a pedantic lint and recommends returningcore::future::readyto reduce the generated future state machine.The same documentation notes that the rewrite is not behaviorally identical:
future::readycomputes the value immediately, while anasyncmethod defers computation until the future is polled. This workspace enables pedantic Clippy lints and denies warnings in CI, so Rust 1.98 turned these existing interface implementations into a hard failure. We keep their current evaluation behavior and suppress this specific lint centrally instead of rewriting production and test handlers.Verification