Skip to content

chore: allow unused async trait handlers - #111

Open
lucarlig wants to merge 3 commits into
mainfrom
user/luca/fix-unused-async-handlers
Open

chore: allow unused async trait handlers#111
lucarlig wants to merge 3 commits into
mainfrom
user/luca/fix-unused-async-handlers

Conversation

@lucarlig

@lucarlig lucarlig commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allow clippy::unused_async_trait_impl at workspace scope
  • keep the existing async trait implementations unchanged

This is the one-line bottom PR beneath #107 and #109.

Why this lint is allowed

Clippy's unused_async_trait_impl documentation explains that the lint flags async trait-method implementations with no .await. It was added in Rust 1.98 as a pedantic lint and recommends returning core::future::ready to reduce the generated future state machine.

The same documentation notes that the rewrite is not behaviorally identical: future::ready computes the value immediately, while an async method defers computation until the future is polled. This workspace enables pedantic Clippy lints and denies warnings in CI, so Rust 1.98 turned these existing interface implementations into a hard failure. We keep their current evaluation behavior and suppress this specific lint centrally instead of rewriting production and test handlers.

Verification

  • Rust 1.98 workspace Clippy with warnings denied
  • Rust 1.96 workspace Clippy completes with its expected unknown-lint compatibility warning
  • repository commit hooks: fmt, Clippy, deny, nextest, and build

Signed-off-by: lucarlig <luca.carlig@ibm.com>
@lucarlig
lucarlig marked this pull request as ready for review August 21, 2026 16:47
This reverts commit 5f5f497.

Signed-off-by: lucarlig <luca.carlig@ibm.com>
Signed-off-by: lucarlig <luca.carlig@ibm.com>
@lucarlig lucarlig changed the title fix: avoid unused async trait handlers chore: allow unused async trait handlers Aug 24, 2026
@lucarlig
lucarlig requested a review from dawid-nowak August 24, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants