Open
Conversation
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
kirtesh-cstk
approved these changes
Apr 20, 2026
kirtesh-cstk
left a comment
There was a problem hiding this comment.
LGTM...merge it to develop_v4 and get it tested on dev22 with all the three features: live preview, timeline and visual builder
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔒 Security Updates: Fix Critical Vulnerabilities in lodash-es and dompurify
Summary
This PR addresses critical security vulnerabilities identified by Snyk in two key dependencies:
4.17.23→4.18.1(fixes 2 critical issues)3.3.3→3.4.0(fixes 1 medium severity issue)🚨 Security Issues Resolved
lodash-es (Risk Score: 240 - HIGH)
_.templateimports (CVSS 8.6)_.unset/_.omit(CVSS 6.9)dompurify (Risk Score: 104 - MEDIUM)
✅ Safety Assessment
SAFE TO DEPLOY - No Breaking Changes Affect Our Codebase
After thorough analysis of our codebase usage patterns:
lodash-es Usage Analysis
Our codebase uses these safe lodash-es functions:
🔍 Potentially Affected Functions (NOT USED in our codebase):
_.unset()- ❌ Not found in codebase_.omit()- ❌ Not found in codebase_.template()- ❌ Not found in codebasedompurify Usage Analysis
Our codebase has minimal, safe usage:
🔍 Enhanced Security: The
USE_PROFILESconfiguration we use is now more secure against prototype pollution.🧪 Testing Results
📊 Risk Assessment
🔄 What Changed
lodash-es 4.18.1
_.unset()/_.omit()_.template()imports for code injectiondompurify 3.4.0
FORBID_TAGSnow properly overridesADD_TAGS🚀 Deployment Recommendation
IMMEDIATE DEPLOYMENT RECOMMENDED
This is a security-critical update with:
📝 Additional Notes
Reviewed by: Security analysis confirms safe deployment
Test Status: ✅ 748/748 tests passing
Security Status: ✅ Critical vulnerabilities resolved