fix: paginate repositories and parse all remote URL formats#176
Open
Harshi-Shah-CS wants to merge 1 commit into
Open
fix: paginate repositories and parse all remote URL formats#176Harshi-Shah-CS wants to merge 1 commit into
Harshi-Shah-CS wants to merge 1 commit into
Conversation
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
| const edges = repositories?.edges ?? []; | ||
| repositoriesRes.push(...map(edges, 'node')); | ||
|
|
||
| // Paginate while a full page is returned; the backend's hasNextPage is unreliable. |
There was a problem hiding this comment.
Why is the backend's hasNextPage is unreliable.?
| } | ||
|
|
||
| let repositories; | ||
| let repositories: any[] = []; |
There was a problem hiding this comment.
Can we have a defined type instead of any?
tejas-contentstack
approved these changes
Jun 10, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub adapter’s repository discovery to support paginated repository fetching and to correctly parse additional GitHub remote URL formats (notably HTTPS remotes that include userinfo). This helps the CLI locate the current repo even when it’s not in the first page of repositories returned to the GitHub App.
Changes:
- Replace the repositories GraphQL query with a paginated
GitRepositoriesquery shape (edges/pageInfo) and add variables forfirst/page. - Add recursive repository pagination in the GitHub adapter (capped at
MAX_REPOSITORY_PAGES) and expand remote URL parsing to handle more HTTPS/SSH formats. - Extend adapter tests to cover userinfo URLs, multi-page lookup, and pagination capping; bump package version.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/graphql/queries.ts | Switch repositories query to a paginated GitRepositories query with first/page variables and edges response shape. |
| src/adapters/github.ts | Add pagination helper for repositories, update flow to select org earlier, and broaden GitHub remote URL parsing regexes. |
| src/adapters/github.test.ts | Update mocks for new query response shape and add tests for userinfo URL parsing + pagination behaviors. |
| package.json | Bump package version to 1.11.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+337
to
340
| let repositories: any[] = []; | ||
| try { | ||
| const repositoriesQueryResponse = await this.apolloClient.query({ query: repositoriesQuery }); | ||
| repositories = repositoriesQueryResponse.data.repositories; | ||
| repositories = await this.queryRepositories({ page: 1, first: 100 }); | ||
| } catch { |
Comment on lines
+372
to
+391
| async queryRepositories(variables: Record<string, any>, repositoriesRes: any[] = []): Promise<any[]> { | ||
| const { data: { repositories } } = await this.apolloClient.query({ | ||
| query: repositoriesQuery, | ||
| variables, | ||
| }); | ||
|
|
||
| const edges = repositories?.edges ?? []; | ||
| repositoriesRes.push(...map(edges, 'node')); | ||
|
|
||
| // Paginate while a full page is returned; the backend's hasNextPage is unreliable. | ||
| if (edges.length === variables.first) { | ||
| if ((variables.page ?? 1) >= MAX_REPOSITORY_PAGES) { | ||
| return repositoriesRes; | ||
| } | ||
| variables.page = (variables.page ?? 1) + 1; | ||
| return await this.queryRepositories(variables, repositoriesRes); | ||
| } | ||
|
|
||
| return repositoriesRes; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.